Remove usage of MediaCodec.getName(), use proxy instead.

media/gpu/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/android_video_decode_accelerator.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 1398 matching lines @@
   // Note that async codec construction might still be in progress.  In that
   // case, the codec will be deleted when it completes once we invalidate all
   // our weak refs.
   weak_this_factory_.InvalidateWeakPtrs();
   if (media_codec_) {
     manager->StopTimer(this);
     // If codec construction is broken, then we can't release this codec if it's
     // backed by hardware, else it may hang too.  Post it to the construction
     // thread, and it'll get freed if things start working.  If things are
     // already working, then it'll be freed soon.
-    if (media_codec_->IsSoftwareCodec()) {
+    //
+    // We require software codecs when |allow_autodetection_| is false, so use
+    // the stored value as a proxy for whether the MediaCodec is software backed
+    // or not.
+    if (!codec_config_->allow_autodetection_) {

[liberato (no reviews please), 2016/06/30 14:59:27]

it'll leak software codecs when mediaserver first hangs, but i suppose that's
not a likely case.

also, this makes me realize that we should do the same thing in
OnCodecConfigured when assigning the new codec.

       media_codec_.reset();
     } else {
       manager->ConstructionTaskRunner()->DeleteSoon(FROM_HERE,
                                                     media_codec_.release());
     }
   }
   delete this;
 }
 
 bool AndroidVideoDecodeAccelerator::TryToSetupDecodeOnSeparateThread(
@@ skipping 320 matching lines @@
       // http://crbug.com/582170
       capabilities.flags |= media::VideoDecodeAccelerator::Capabilities::
           SUPPORTS_EXTERNAL_OUTPUT_SURFACE;
     }
   }
 
   return capabilities;
 }
 
 }  // namespace media