Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Add unit tests for positive and negative scale factors for the two effects that
apply a Gaussian blur like this: blur and drop-shadow. The last two assertions
fail without the fix in SkDropShadowImageFilter.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002

Committed: https://skia.googlesource.com/skia/+/203a993c77ea146e0a4e7f1e0c079cc79fd09167

[jbroman, 2016-07-03 00:23:38]

Description was changed from

==========
need SkScalarAbs in SkDropShadowImageFilter::onFilterNodeBounds

Still needs a unit test, aside from the one I'm gonna land in chromim.

BUG=skia:
==========

to

==========
need SkScalarAbs in SkDropShadowImageFilter::onFilterNodeBounds

Still needs a unit test, aside from the one I'm gonna land in chromim.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

[jbroman, 2016-07-07 19:43:15]

Description was changed from

==========
need SkScalarAbs in SkDropShadowImageFilter::onFilterNodeBounds

Still needs a unit test, aside from the one I'm gonna land in chromim.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

to

==========
Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Still needs a unit test, aside from the one I'm gonna land in chromim.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

[jbroman, 2016-07-07 20:24:41]

Description was changed from

==========
Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Still needs a unit test, aside from the one I'm gonna land in chromim.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

to

==========
Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Add unit tests for positive and negative scale factors for the two effects that
apply a Gaussian blur like this: blur and drop-shadow. The last two assertions
fail without the fix in SkDropShadowImageFilter.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

[jbroman, 2016-07-07 20:25:51]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 20:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-07-07 20:26:10]

jbroman@chromium.org changed reviewers:
+ fmalita@chromium.org

[jbroman, 2016-07-07 20:26:10]

senorblanco is still OOO; you mind having a look?

[commit-bot: I haz the power, 2016-07-07 20:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 20:52:08]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-07-11 20:34:48]

ping

[f(malita), 2016-07-11 20:37:41]

lgtm

[jbroman, 2016-07-11 20:43:25]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-07-11 20:43:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 21:08:02]

Description was changed from

==========
Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Add unit tests for positive and negative scale factors for the two effects that
apply a Gaussian blur like this: blur and drop-shadow. The last two assertions
fail without the fix in SkDropShadowImageFilter.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002
==========

to

==========
Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Add unit tests for positive and negative scale factors for the two effects that
apply a Gaussian blur like this: blur and drop-shadow. The last two assertions
fail without the fix in SkDropShadowImageFilter.

BUG=chromium:600821
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114313002

Committed:
https://skia.googlesource.com/skia/+/203a993c77ea146e0a4e7f1e0c079cc79fd09167
==========

[commit-bot: I haz the power, 2016-07-11 21:08:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/203a993c77ea146e0a4e7f1e0c079cc79fd09167

[Stephen White, 2016-07-12 16:25:23]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-07-12 16:25:24]

https://codereview.chromium.org/2114313002/diff/20001/src/effects/SkDropShado...
File src/effects/SkDropShadowImageFilter.cpp (right):

https://codereview.chromium.org/2114313002/diff/20001/src/effects/SkDropShado...
src/effects/SkDropShadowImageFilter.cpp:143:
SkScalarCeilToInt(SkScalarAbs(SkScalarMul(sigma.x(), SkIntToScalar(3)))),
There's probably a similar bug in SkDSIF::computeFastBounds().

[jbroman, 2016-07-12 16:45:10]

On 2016/07/12 at 16:25:24, senorblanco wrote:
>
https://codereview.chromium.org/2114313002/diff/20001/src/effects/SkDropShado...
> File src/effects/SkDropShadowImageFilter.cpp (right):
> 
>
https://codereview.chromium.org/2114313002/diff/20001/src/effects/SkDropShado...
> src/effects/SkDropShadowImageFilter.cpp:143:
SkScalarCeilToInt(SkScalarAbs(SkScalarMul(sigma.x(), SkIntToScalar(3)))),
> There's probably a similar bug in SkDSIF::computeFastBounds().

computeFastBounds doesn't take a matrix, so I don't believe it's vulnerable to
this issue.