src/effects/SkDropShadowImageFilter.cpp - Issue 2114313002: Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDropShadowImageFilter.cpp

Issue 2114313002: Handle negative scale in SkDropShadowImageFilter::onFilterNodeBounds. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: I can has unit test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkDropShadowImageFilter.cpp

diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp

index 31c45082b23520ee069a7a98aa534356fb883d7c..5befe711942746819abd8ce579ec9a540fdd67b2 100644

--- a/src/effects/SkDropShadowImageFilter.cpp

+++ b/src/effects/SkDropShadowImageFilter.cpp

@@ -139,8 +139,9 @@ SkIRect SkDropShadowImageFilter::onFilterNodeBounds(const SkIRect& src, const Sk

SkScalarCeilToInt(offsetVec.y()));

SkVector sigma = SkVector::Make(fSigmaX, fSigmaY);

ctm.mapVectors(&sigma, 1);

- dst.outset(SkScalarCeilToInt(SkScalarMul(sigma.x(), SkIntToScalar(3))),

- SkScalarCeilToInt(SkScalarMul(sigma.y(), SkIntToScalar(3))));

+ dst.outset(

+ SkScalarCeilToInt(SkScalarAbs(SkScalarMul(sigma.x(), SkIntToScalar(3)))),

Stephen White 2016/07/12 16:25:23 There's probably a similar bug in SkDSIF::computeF

+ SkScalarCeilToInt(SkScalarAbs(SkScalarMul(sigma.y(), SkIntToScalar(3)))));

if (fShadowMode == kDrawShadowAndForeground_ShadowMode) {

dst.join(src);

}

« no previous file with comments | « no previous file | tests/ImageFilterTest.cpp » ('j') | no next file with comments »