Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306
Committed: https://crrev.com/caeab66e9354dc437d57c10895af44ae585442a0
Cr-Commit-Position: refs/heads/master@{#403975}

[pkotwicz, 2016-07-01 21:55:06]

Description was changed from

==========
Launch Chrome in non-WebAPK mode in WebAPK runtime library cannot be loaded

BUG=625302
==========

to

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625302
==========

[pkotwicz, 2016-07-01 22:01:29]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-07-01 22:01:29]

Xi can you please take a look?

[pkotwicz, 2016-07-01 22:02:58]

Description was changed from

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625302
==========

to

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306
==========

[Xi Han, 2016-07-05 14:31:51]

https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:33:
private static final String REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB =
Nit: please put a note here that this constant must stay in sync with
TabOpenType.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB.

https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:93:
intent.putExtra(REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);
intent.putExtra(EXTRA_SOURCE, getIntExtra(EXTRA_SOURCE, 0)) and add the constant
for EXTRA_SOURCE.
It is not ideal to introduce another constant, but I think it is better to add
the source for the intent.

[pkotwicz, 2016-07-05 18:47:36]

Xi can you please take another look?

https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
(right):

https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:93:
intent.putExtra(REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);
You are right that we need to do this in order to match the behavior of
WebappLauncherActivity#onCreate() when the WebAPK is not valid

[Xi Han, 2016-07-05 18:53:33]

Thanks for submitting this CL to handle the runtime library unloaded case!

lgtm!

https://codereview.chromium.org/2114173002/diff/20001/chrome/android/webapk/l...
File
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
(right):

https://codereview.chromium.org/2114173002/diff/20001/chrome/android/webapk/l...
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java:36:
"org.chromium.chrome.browser.webapk_package_name";
Hopefully we don't need to change this file often after shipping WebAPKs.

[pkotwicz, 2016-07-06 15:44:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-07-06 15:45:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 16:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 16:04:18]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pkotwicz, 2016-07-06 20:10:30]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-07-06 20:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2114173002/#ps40001
(title: "Merge branch 'master' into webapk_more_meta2_loader2")

[commit-bot: I haz the power, 2016-07-06 20:11:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:34:33]

Description was changed from

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306
==========

to

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306
==========

[commit-bot: I haz the power, 2016-07-06 23:34:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 23:34:57]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 23:36:51]

Description was changed from

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306
==========

to

==========
Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

BUG=625306

Committed: https://crrev.com/caeab66e9354dc437d57c10895af44ae585442a0
Cr-Commit-Position: refs/heads/master@{#403975}
==========

[commit-bot: I haz the power, 2016-07-06 23:36:52]

Patchset 3 (id:??) landed as
https://crrev.com/caeab66e9354dc437d57c10895af44ae585442a0
Cr-Commit-Position: refs/heads/master@{#403975}