Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2114173002: Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded BUG=625306 Committed: https://crrev.com/caeab66e9354dc437d57c10895af44ae585442a0 Cr-Commit-Position: refs/heads/master@{#403975}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Merge branch 'master' into webapk_more_meta2_loader2 #

Total comments: 1

Patch Set 3 : Merge branch 'master' into webapk_more_meta2_loader2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -30 lines) Patch
M chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java View 1 3 chunks +11 lines, -27 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 1 4 chunks +59 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
pkotwicz
Xi can you please take a look?
4 years, 5 months ago (2016-07-01 22:01:29 UTC) #3
Xi Han
https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java File chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java (right): https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java#newcode33 chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:33: private static final String REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB = Nit: please put ...
4 years, 5 months ago (2016-07-05 14:31:51 UTC) #5
pkotwicz
Xi can you please take another look? https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java File chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java (right): https://codereview.chromium.org/2114173002/diff/1/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java#newcode93 chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:93: intent.putExtra(REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true); ...
4 years, 5 months ago (2016-07-05 18:47:36 UTC) #6
Xi Han
Thanks for submitting this CL to handle the runtime library unloaded case! lgtm! https://codereview.chromium.org/2114173002/diff/20001/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java File ...
4 years, 5 months ago (2016-07-05 18:53:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114173002/20001
4 years, 5 months ago (2016-07-06 15:45:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/92097)
4 years, 5 months ago (2016-07-06 16:04:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114173002/40001
4 years, 5 months ago (2016-07-06 20:11:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 23:34:33 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:34:57 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:36:52 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/caeab66e9354dc437d57c10895af44ae585442a0
Cr-Commit-Position: refs/heads/master@{#403975}

Powered by Google App Engine
This is Rietveld 408576698