chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java - Issue 2114173002: Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

Issue 2114173002: Launch Chrome in non-WebAPK mode if WebAPK runtime library cannot be loaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_more_meta2_loader2 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

diff --git a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

index f797ed6fb764a8eeeac41affa4d34d4d332dd99e..c1efbeeb085a17881e4786562cc74bf5e2d94c20 100644

--- a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

+++ b/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java

@@ -18,4 +18,20 @@ public final class WebApkConstants {

"org.chromium.webapk.lib.common.webapk_display_mode";

public static final String EXTRA_WEBAPK_ORIENTATION =

"org.chromium.webapk.lib.common.webapk_orientation";

+ // These EXTRA_* values must stay in sync with

+ // {@link org.chromium.chrome.browser.ShortcutHelper}.

+ public static final String EXTRA_ID = "org.chromium.chrome.browser.webapp_id";

+ public static final String EXTRA_ICON = "org.chromium.chrome.browser.webapp_icon";

+ public static final String EXTRA_SHORT_NAME = "org.chromium.chrome.browser.webapp_short_name";

+ public static final String EXTRA_NAME = "org.chromium.chrome.browser.webapp_name";

+ public static final String EXTRA_URL = "org.chromium.chrome.browser.webapp_url";

+ public static final String EXTRA_SOURCE = "org.chromium.chrome.browser.webapp_source";

+ public static final String EXTRA_THEME_COLOR = "org.chromium.chrome.browser.theme_color";

+ public static final String EXTRA_BACKGROUND_COLOR =

+ "org.chromium.chrome.browser.background_color";

+ public static final String EXTRA_IS_ICON_GENERATED =

+ "org.chromium.chrome.browser.is_icon_generated";

+ public static final String EXTRA_WEBAPK_PACKAGE_NAME =

+ "org.chromium.chrome.browser.webapk_package_name";

}