Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: LayoutTests/media/audio-delete-while-slider-thumb-clicked.html

Issue 211403003: Add a missing null check in SliderThumbElement::stopDragging() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/audio-delete-while-slider-thumb-clicked.html
diff --git a/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html b/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html
index 052dadf5fb3193809f73e0e96ab667f229e23143..59959c8067ecdbbefd7e496ec49bc68dbe43edf9 100644
--- a/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html
+++ b/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html
@@ -15,9 +15,12 @@
var console = document.getElementById('console');
console.innerHTML = console.innerHTML + msg + "<br>";
}
-
+
function buttonClick()
{
+ if (window.GCController)
acolwell GONE FROM CHROMIUM 2014/03/25 22:28:57 nit: I think you should move this into deleteAudio
philipj_slow 2014/03/26 08:15:32 Ahem... this code was copied from adopt-node-crash
+ return GCController.collect();
+
if (document.getElementById('audio'))
log("<br>FAIL: audio element not deleted!!");
@@ -31,7 +34,7 @@
testRunner.notifyDone();
}
-
+
function deleteAudio()
{
var audio = document.getElementById('audio');
@@ -43,7 +46,7 @@
setTimeout(buttonClick, 10);
}
-
+
function drag()
{
if (!window.testRunner)
« no previous file with comments | « no previous file | Source/core/html/shadow/SliderThumbElement.cpp » ('j') | Source/core/html/shadow/SliderThumbElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698