LayoutTests/media/audio-delete-while-slider-thumb-clicked.html - Issue 211403003: Add a missing null check in SliderThumbElement::stopDragging()

Side by Side Diff: LayoutTests/media/audio-delete-while-slider-thumb-clicked.html

Issue 211403003: Add a missing null check in SliderThumbElement::stopDragging() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=media-file.js></script>	4 <script src=media-file.js></script>

5 <script src=video-test.js></script>	5 <script src=video-test.js></script>

6 <script src=media-controls.js></script>	6 <script src=media-controls.js></script>

7 <script>	7 <script>

8 if (window.testRunner) {	8 if (window.testRunner) {

9 testRunner.dumpAsText();	9 testRunner.dumpAsText();

10 testRunner.waitUntilDone();	10 testRunner.waitUntilDone();

11 }	11 }

12	12

13 function log(msg)	13 function log(msg)

14 {	14 {

15 var console = document.getElementById('console');	15 var console = document.getElementById('console');

16 console.innerHTML = console.innerHTML + msg + "<br>";	16 console.innerHTML = console.innerHTML + msg + "<br>";

17 }	17 }

18	18

19 function buttonClick()	19 function buttonClick()

20 {	20 {

	21 if (window.GCController)
	acolwell GONE FROM CHROMIUM 2014/03/25 22:28:57 nit: I think you should move this into deleteAudio nit: I think you should move this into deleteAudio() since this clearly isn't a button click and it's a little confusing to have it here. Adding a comment about why you GC in some testing environments and force a click in others would be nice. philipj_slow 2014/03/26 08:15:32 Ahem... this code was copied from adopt-node-crash Show quoted text On 2014/03/25 22:28:57, acolwell wrote: > nit: I think you should move this into deleteAudio() since this clearly isn't a > button click and it's a little confusing to have it here. Adding a comment about > why you GC in some testing environments and force a click in others would be > nice. Ahem... this code was copied from adopt-node-crash.html, but I messed up by copying the return as well, fortunately you didn't miss it! I didn't put it in deleteAudio() because that's run in an event listener for the audio element, and the audio element cannot be collected at that point, at least not in my testing. I'll fix this by copying all of forceGC() instead, which should make things clearer.
	22 return GCController.collect();

	23

21 if (document.getElementById('audio'))	24 if (document.getElementById('audio'))

22 log("<br>FAIL: audio element not deleted!!");	25 log("<br>FAIL: audio element not deleted!!");

23	26

24 log("<br>clicking button");	27 log("<br>clicking button");

25	28

26 // click the button	29 // click the button

27 var button = document.getElementById('button');	30 var button = document.getElementById('button');

28 eventSender.mouseMoveTo(button.offsetLeft + 20, button.offsetTop + 7);	31 eventSender.mouseMoveTo(button.offsetLeft + 20, button.offsetTop + 7);

29 eventSender.mouseDown();	32 eventSender.mouseDown();

30 eventSender.mouseUp();	33 eventSender.mouseUp();

31	34

32 testRunner.notifyDone();	35 testRunner.notifyDone();

33 }	36 }

34	37

35 function deleteAudio()	38 function deleteAudio()

36 {	39 {

37 var audio = document.getElementById('audio');	40 var audio = document.getElementById('audio');

38 if (!audio)	41 if (!audio)

39 return;	42 return;

40	43

41 log("<br>deleting audio element");	44 log("<br>deleting audio element");

42 audio.parentNode.removeChild(audio);	45 audio.parentNode.removeChild(audio);

43	46

44 setTimeout(buttonClick, 10);	47 setTimeout(buttonClick, 10);

45 }	48 }

46	49

47 function drag()	50 function drag()

48 {	51 {

49 if (!window.testRunner)	52 if (!window.testRunner)

50 return;	53 return;

51	54

52 testRunner.dumpAsText();	55 testRunner.dumpAsText();

53 testRunner.waitUntilDone();	56 testRunner.waitUntilDone();

54	57

55 var audio = document.getElementById('audio');	58 var audio = document.getElementById('audio');

56 var seekCoords;	59 var seekCoords;

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 </head>	91 </head>

89 <body onload="start()">	92 <body onload="start()">

90 This tests that events don't continue to target a slider thumb if the me dia element is deleted while scrubbing.	93 This tests that events don't continue to target a slider thumb if the me dia element is deleted while scrubbing.

91 <br>	94 <br>

92 <input type="button" id="button" value="Click Me!" onmouseup="log('butto n click!')">	95 <input type="button" id="button" value="Click Me!" onmouseup="log('butto n click!')">

93 <br>	96 <br>

94 <audio id="audio" autoplay onplaying="drag()" controls></audio><br><br>	97 <audio id="audio" autoplay onplaying="drag()" controls></audio><br><br>

95 <div id="console"></div>	98 <div id="console"></div>

96 </body>	99 </body>

97 </html>	100 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/html/shadow/SliderThumbElement.cpp » ('j') | Source/core/html/shadow/SliderThumbElement.cpp » ('J')