third_party/WebKit/Source/core/svg/SVGLength.h - Issue 2113943003: SVGLength.value setter should set the value to <number>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.h

Issue 2113943003: SVGLength.value setter should set the value to <number> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dom/SVGLength-value-setter.html ('k') | third_party/WebKit/Source/core/svg/SVGLength.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLength.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.h b/third_party/WebKit/Source/core/svg/SVGLength.h

index 91ce36d105c12ae1e5ef30c0cc8400a4381c7e0e..077aa33a5dcce106d06d42fe560704f0b3b006f0 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.h

+++ b/third_party/WebKit/Source/core/svg/SVGLength.h

@@ -56,6 +56,7 @@ public:

float value(const SVGLengthContext&) const;

void setValue(float, const SVGLengthContext&);

+ void setValueAsNumber(float);

float valueInSpecifiedUnits() const { return m_value->getFloatValue(); }

void setValueInSpecifiedUnits(float value)