third_party/WebKit/Source/core/svg/SVGLength.cpp - Issue 2113943003: SVGLength.value setter should set the value to <number>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.cpp

Issue 2113943003: SVGLength.value setter should set the value to <number> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.cpp b/third_party/WebKit/Source/core/svg/SVGLength.cpp

index 8d66d974af40ea2aa6faf4d7a18ca2a7ebf75b5a..baca6224015d143522ff80038003daa4c906a100 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLength.cpp

@@ -77,6 +77,11 @@ float SVGLength::value(const SVGLengthContext& context) const

m_value->getFloatValue(), unitMode(), m_value->typeWithCalcResolved());

}

+void SVGLength::setValueAsNumber(float value)

+ m_value = CSSPrimitiveValue::create(value, CSSPrimitiveValue::UnitType::UserUnits);

void SVGLength::setValue(float value, const SVGLengthContext& context)

{

m_value = CSSPrimitiveValue::create(

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLength.h ('k') | third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp » ('j') | no next file with comments »