Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.cpp

Issue 2113943003: SVGLength.value setter should set the value to <number> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGLength.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGLength.cpp b/third_party/WebKit/Source/core/svg/SVGLength.cpp
index 8d66d974af40ea2aa6faf4d7a18ca2a7ebf75b5a..9baa811f2c1f63d5550b0ecd1583a83abfce7394 100644
--- a/third_party/WebKit/Source/core/svg/SVGLength.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGLength.cpp
@@ -79,9 +79,7 @@ float SVGLength::value(const SVGLengthContext& context) const
void SVGLength::setValue(float value, const SVGLengthContext& context)
fs 2016/07/01 09:08:05 This method is used in a few more places besides S
Shanmuga Pandi 2016/07/01 10:27:13 Done.
{
- m_value = CSSPrimitiveValue::create(
- context.convertValueFromUserUnits(value, unitMode(), m_value->typeWithCalcResolved()),
- m_value->typeWithCalcResolved());
+ m_value = CSSPrimitiveValue::create(value, CSSPrimitiveValue::UnitType::UserUnits);
}
bool isSupportedCSSUnitType(CSSPrimitiveValue::UnitType type)

Powered by Google App Engine
This is Rietveld 408576698