SVGLength.value setter should set the value to <number>

third_party/WebKit/Source/core/svg/SVGLength.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 59 matching lines @@
 {
     return m_unitMode == other.m_unitMode && m_value == other.m_value;
 }
 
 float SVGLength::value(const SVGLengthContext& context) const
 {
     return context.convertValueToUserUnits(
         m_value->getFloatValue(), unitMode(), m_value->typeWithCalcResolved());
 }
 
 void SVGLength::setValue(float value, const SVGLengthContext& context)

[fs, 2016/07/01 09:08:05]

This method is used in a few more places besides SVGLengthTearOff, so adding a
new setValueAsNumber or so would be the more cautious approach. I think we
should be able to eliminate the other setValue uses later on.

[Shanmuga Pandi, 2016/07/01 10:27:13]

Done.

 {
-    m_value = CSSPrimitiveValue::create(
-        context.convertValueFromUserUnits(value, unitMode(), m_value->typeWithCalcResolved()),
-        m_value->typeWithCalcResolved());
+    m_value = CSSPrimitiveValue::create(value, CSSPrimitiveValue::UnitType::UserUnits);
 }
 
 bool isSupportedCSSUnitType(CSSPrimitiveValue::UnitType type)
 {
     return (CSSPrimitiveValue::isLength(type) || type == CSSPrimitiveValue::UnitType::Number || type == CSSPrimitiveValue::UnitType::Percentage)
         && type != CSSPrimitiveValue::UnitType::QuirkyEms;
 }
 
 void SVGLength::setUnitType(CSSPrimitiveValue::UnitType type)
 {
@@ skipping 161 matching lines @@
 
 float SVGLength::calculateDistance(SVGPropertyBase* toValue, SVGElement* contextElement)
 {
     SVGLengthContext lengthContext(contextElement);
     SVGLength* toLength = toSVGLength(toValue);
 
     return fabsf(toLength->value(lengthContext) - value(lengthContext));
 }
 
 } // namespace blink