Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 211393007: Backport https://code.google.com/p/v8/source/detail?r=19360 to 3.24.35 (Closed)

Created:
6 years, 9 months ago by trevnorris
Modified:
6 years, 8 months ago
Reviewers:
trevnorris, danno
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@3.24
Visibility:
Public.

Description

Backport https://code.google.com/p/v8/source/detail?r=19360 to 3.24.35 Also bumped patch level. R=trev.norris@gmail.com BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -134 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 3 chunks +5 lines, -0 lines 0 comments Download
M src/compiler.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen.h View 17 chunks +72 lines, -17 lines 0 comments Download
M src/hydrogen.cc View 41 chunks +177 lines, -50 lines 0 comments Download
M src/hydrogen-instructions.h View 10 chunks +92 lines, -32 lines 0 comments Download
M src/hydrogen-instructions.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M src/hydrogen-representation-changes.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/isolate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
trevnorris
6 years, 9 months ago (2014-03-26 04:23:38 UTC) #1
trevnorris
The CQ bit was checked by trev.norris@gmail.com
6 years, 9 months ago (2014-03-26 04:27:36 UTC) #2
trevnorris
The CQ bit was unchecked by trev.norris@gmail.com
6 years, 9 months ago (2014-03-26 04:27:37 UTC) #3
trevnorris
On 2014/03/26 04:23:38, trevnorris wrote: Reason for this backport is because Node.js will be releasing ...
6 years, 9 months ago (2014-03-26 04:33:12 UTC) #4
Sven Panne
On 2014/03/26 04:33:12, trevnorris wrote: > Reason for this backport is because Node.js will be ...
6 years, 9 months ago (2014-03-26 07:59:53 UTC) #5
danno
This patch is neither a critical stability or performance fix, and it's non-trivial in size. ...
6 years, 8 months ago (2014-03-31 07:52:05 UTC) #6
trevnorris
6 years, 8 months ago (2014-04-01 18:51:58 UTC) #7
On 2014/03/31 07:52:05, danno wrote:
> This patch is neither a critical stability or performance fix, and it's
> non-trivial in size. The benefit/rish ratio is too low at this point to
approve
> a back merge. Sorry!

No worries. Knew it was a long shot, but figured I'd give it a go.

Thanks for taking a look anyways. :)

Powered by Google App Engine
This is Rietveld 408576698