Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2113893004: [turbofan] Fix eager bailout point after comma expression. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix eager bailout point after comma expression. This ensures no eager bailout point is emitted after a comma expression in test context where the right-hand side omitted an eager bailout point as well. This is to stay in sync with full-codegen. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-624919 BUG=chromium:624919 Committed: https://crrev.com/920bc17c97676a238ce079ac569a827b64fcd817 Cr-Commit-Position: refs/heads/master@{#37475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-624919.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-01 09:38:06 UTC) #1
Jarin
lgtm. Thanks!
4 years, 5 months ago (2016-07-01 09:44:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113893004/1
4 years, 5 months ago (2016-07-01 09:48:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 09:50:44 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 09:52:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/920bc17c97676a238ce079ac569a827b64fcd817
Cr-Commit-Position: refs/heads/master@{#37475}

Powered by Google App Engine
This is Rietveld 408576698