Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2113893004: [turbofan] Fix eager bailout point after comma expression. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-624919.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 73ab72c333f1773a83c9581c2e396fcee3c4568f..c995ac83ec512d2595b501757b1e7e8f6cd3d9cb 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -3052,6 +3052,10 @@ void AstGraphBuilder::VisitNot(UnaryOperation* expr) {
void AstGraphBuilder::VisitComma(BinaryOperation* expr) {
VisitForEffect(expr->left());
Visit(expr->right());
+ // Skip plugging AST evaluation contexts of the test kind. This is to stay in
+ // sync with full codegen which doesn't prepare the proper bailout point (see
+ // the implementation of FullCodeGenerator::VisitForControl).
+ if (ast_context()->IsTest()) return;
ast_context()->ReplaceValue(expr);
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-624919.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698