Attempt to un-flake RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

Attempt to un-flake RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

This test has been failing flakily in Windows Clang debug builds for a while. I
can reproduce the failure locally, and this patch makes it go away.

It seems there's a race between document.referrer being set and the test
checking for it. Other tests in this file do "Wait for the cross-site
transition in the new tab to finish" before checking the referer, so let's do
that here too.

BUG=624523
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d662b254af5421e0b53b67f561377657fcd67686
Cr-Commit-Position: refs/heads/master@{#403452}

[hans, 2016-06-30 23:39:49]

Description was changed from

==========
Attempt to un-flake
RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

This test has been failing flakily in Windows Clang debug builds for a while. I
can reproduce the failure locally, and this patch makes it go away.

It seems there's a race between document.referrer being set and the test
checking for it. Other tests in this file do "Wait for the cross-site
transition in the new tab to finish" before checking the referer, so let's do
that here too.

BUG=624523
==========

to

==========
Attempt to un-flake
RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

This test has been failing flakily in Windows Clang debug builds for a while. I
can reproduce the failure locally, and this patch makes it go away.

It seems there's a race between document.referrer being set and the test
checking for it. Other tests in this file do "Wait for the cross-site
transition in the new tab to finish" before checking the referer, so let's do
that here too.

BUG=624523
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[hans, 2016-06-30 23:40:34]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 23:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2016-07-01 00:02:41]

hans@chromium.org changed reviewers:
+ clamy@chromium.org, mkwst@chromium.org

[hans, 2016-07-01 00:02:41]

Please take a look.

[commit-bot: I haz the power, 2016-07-01 00:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 00:28:19]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-07-01 14:30:55]

Thanks! Lgtm - it seems reasonable to wait for the pending RFH to have been
swapped in.

[Nico, 2016-07-01 14:33:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:34:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 14:38:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 14:38:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 14:40:15]

Description was changed from

==========
Attempt to un-flake
RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

This test has been failing flakily in Windows Clang debug builds for a while. I
can reproduce the failure locally, and this patch makes it go away.

It seems there's a race between document.referrer being set and the test
checking for it. Other tests in this file do "Wait for the cross-site
transition in the new tab to finish" before checking the referer, so let's do
that here too.

BUG=624523
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Attempt to un-flake
RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank

This test has been failing flakily in Windows Clang debug builds for a while. I
can reproduce the failure locally, and this patch makes it go away.

It seems there's a race between document.referrer being set and the test
checking for it. Other tests in this file do "Wait for the cross-site
transition in the new tab to finish" before checking the referer, so let's do
that here too.

BUG=624523
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d662b254af5421e0b53b67f561377657fcd67686
Cr-Commit-Position: refs/heads/master@{#403452}
==========

[commit-bot: I haz the power, 2016-07-01 14:40:16]

Patchset 1 (id:??) landed as
https://crrev.com/d662b254af5421e0b53b67f561377657fcd67686
Cr-Commit-Position: refs/heads/master@{#403452}