Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 2113893002: Attempt to un-flake RenderFrameHostManagerTest.SwapProcessWithRelNoopenerAndTargetBlank (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index 41740c4247bc186857ef7a8c0e3a3bddf2a3af54..23a249db2ce61e8744e0c9ab861297bd60b6b4eb 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -342,6 +342,13 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
&success));
EXPECT_TRUE(success);
+ // Wait for the cross-site transition in the new tab to finish.
+ WaitForLoadStop(new_shell->web_contents());
+ WebContentsImpl* web_contents =
+ static_cast<WebContentsImpl*>(new_shell->web_contents());
+ EXPECT_FALSE(
+ web_contents->GetRenderManagerForTesting()->pending_render_view_host());
+
// Check that the referrer is set correctly.
std::string expected_referrer =
embedded_test_server()->GetURL("/click-noreferrer-links.html").spec();
@@ -352,13 +359,6 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
&success));
EXPECT_TRUE(success);
- // Wait for the cross-site transition in the new tab to finish.
- WaitForLoadStop(new_shell->web_contents());
- WebContentsImpl* web_contents =
- static_cast<WebContentsImpl*>(new_shell->web_contents());
- EXPECT_FALSE(
- web_contents->GetRenderManagerForTesting()->pending_render_view_host());
-
// Should have a new SiteInstance.
scoped_refptr<SiteInstance> noopener_blank_site_instance(
new_shell->web_contents()->GetSiteInstance());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698