components/signin: convert GaiaCookieManagerService to use CanonicalCookie's Create() method.

components/signin/core/browser/gaia_cookie_manager_service.cc

Index: components/signin/core/browser/gaia_cookie_manager_service.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc
index d6b4f01106f052b631d650625200d1f1bbe58e1b..2ccbac1d6bf373e09dd5b0d86ea8e4c881f50d4c 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc
@@ -378,11 +378,11 @@ void GaiaCookieManagerService::TriggerListAccounts() {
 
 void GaiaCookieManagerService::ForceOnCookieChangedProcessing() {
   GURL google_url = GaiaUrls::GetInstance()->google_url();
-  net::CanonicalCookie cookie(
-      google_url, kGaiaCookieName, "", google_url.host(), "", base::Time(),
-      base::Time(), base::Time(), false, false,
-      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
-  OnCookieChanged(cookie, true);
+  std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
+      google_url, kGaiaCookieName, std::string(), google_url.host(),

[tfarina, 2016/07/01 12:20:10]

Matt, I had to keep host() in order to keep the unit test happy, because the
default value for it has a leading dot, see
https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_urls.cc?sq=package...,
but looks like this value can be changed from command line. Should I do
something to handle that possibility or with host() will we go well in any case?

[mmenke, 2016/07/01 16:21:00]

Hrm...that's not a valid URL, and is apparently breaking something as a result.

Rogerta:  Why is kDefaultGoogleUrl not using a valid domain name?

[mmenke, 2016/07/15 18:47:18]

So here's my suggestion (Need to have one of the owners verify it's sane,
though):

replace the url with http://google.com (i.e., remove the dot), and in this code,
replace google_url.host() with: "." + google_url.host()

[tfarina, 2016/07/18 20:00:07]

Done.

+      std::string(), base::Time(), base::Time(), false, false,
+      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+  OnCookieChanged(*cookie, true);
 }
 
 void GaiaCookieManagerService::LogOutAllAccounts() {