components/signin: convert GaiaCookieManagerService to use CanonicalCookie's Create() method.

components/signin/core/browser/gaia_cookie_manager_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 
 #include <stddef.h>
 
 #include <queue>
 #include <vector>
@@ skipping 360 matching lines @@
   } else if (std::find_if(requests_.begin(), requests_.end(),
                           [](const GaiaCookieRequest& request) {
                             return request.request_type() == LIST_ACCOUNTS;
                           }) == requests_.end()) {
     requests_.push_back(GaiaCookieRequest::CreateListAccountsRequest());
   }
 }
 
 void GaiaCookieManagerService::ForceOnCookieChangedProcessing() {
   GURL google_url = GaiaUrls::GetInstance()->google_url();
-  net::CanonicalCookie cookie(
-      google_url, kGaiaCookieName, "", google_url.host(), "", base::Time(),
-      base::Time(), base::Time(), false, false,
-      net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
-  OnCookieChanged(cookie, true);
+  std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
+      google_url, kGaiaCookieName, std::string(), google_url.host(),

[tfarina, 2016/07/01 12:20:10]

Matt, I had to keep host() in order to keep the unit test happy, because the
default value for it has a leading dot, see
https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_urls.cc?sq=package...,
but looks like this value can be changed from command line. Should I do
something to handle that possibility or with host() will we go well in any case?

[mmenke, 2016/07/01 16:21:00]

Hrm...that's not a valid URL, and is apparently breaking something as a result.

Rogerta:  Why is kDefaultGoogleUrl not using a valid domain name?

[mmenke, 2016/07/15 18:47:18]

So here's my suggestion (Need to have one of the owners verify it's sane,
though):

replace the url with http://google.com (i.e., remove the dot), and in this code,
replace google_url.host() with: "." + google_url.host()

[tfarina, 2016/07/18 20:00:07]

Done.

+      std::string(), base::Time(), base::Time(), false, false,
+      net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT));
+  OnCookieChanged(*cookie, true);
 }
 
 void GaiaCookieManagerService::LogOutAllAccounts() {
   VLOG(1) << "GaiaCookieManagerService::LogOutAllAccounts";
 
   bool log_out_queued = false;
   if (!requests_.empty()) {
     // Track requests to keep; all other unstarted requests will be removed.
     std::vector<GaiaCookieRequest> requests_to_keep;
 
@@ skipping 319 matching lines @@
         break;
       case GaiaCookieRequestType::LIST_ACCOUNTS:
         uber_token_fetcher_.reset();
         signin_client_->DelayNetworkCall(
             base::Bind(&GaiaCookieManagerService::StartFetchingListAccounts,
                        base::Unretained(this)));
         break;
     };
   }
 }