Never allow dither for non-legacy (sRGB or F16) targets.

Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113793002

Committed: https://skia.googlesource.com/skia/+/0e1161d03f40fc1638481222b06fb74f6a9c734a

[Brian Osman, 2016-06-30 20:15:58]

Description was changed from

==========
Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
==========

to

==========
Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113793002
==========

[Brian Osman, 2016-06-30 20:16:36]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 20:16:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-06-30 20:17:18]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[jvanverth1, 2016-06-30 20:21:37]

https://codereview.chromium.org/2113793002/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/2113793002/diff/1/src/gpu/SkGr.cpp#newcode658
src/gpu/SkGr.cpp:658: if (skPaint.isDither() &&
grPaint->numColorFragmentProcessors() > 0 && !allowSRGBInputs) {
Does allowSRGBInputs include F16? If so, that seems a little confusing.

[commit-bot: I haz the power, 2016-06-30 20:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:36:56]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-06-30 20:43:31]

On 2016/06/30 at 20:21:37, jvanverth wrote:
> https://codereview.chromium.org/2113793002/diff/1/src/gpu/SkGr.cpp
> File src/gpu/SkGr.cpp (right):
> 
> https://codereview.chromium.org/2113793002/diff/1/src/gpu/SkGr.cpp#newcode658
> src/gpu/SkGr.cpp:658: if (skPaint.isDither() &&
grPaint->numColorFragmentProcessors() > 0 && !allowSRGBInputs) {
> Does allowSRGBInputs include F16? If so, that seems a little confusing.

Yes, and yes. I have other changes that I've been hammering on to rename things.
Here, allowSRGBInputs is actually a synonym for "is the destination of this
paint
'gamma-correct'". That, in turn, means "is the destination sRGB, or F16, or...
anything
other than 'legacy' linear 8888".

[jvanverth1, 2016-06-30 20:45:42]

lgtm, with implied contract that that name will change some day :)

[bsalomon, 2016-06-30 21:14:41]

lgtm

[Brian Osman, 2016-07-13 15:35:06]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-07-13 15:35:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:05:49]

Description was changed from

==========
Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113793002
==========

to

==========
Never allow dither for non-legacy (sRGB or F16) targets.

With sRGB, the noise from dithering is (obviously) non-linear, and
highly objectionable for very dark values. With F16, it's completely
unnecessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113793002

Committed:
https://skia.googlesource.com/skia/+/0e1161d03f40fc1638481222b06fb74f6a9c734a
==========

[commit-bot: I haz the power, 2016-07-13 16:05:50]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0e1161d03f40fc1638481222b06fb74f6a9c734a