src/gpu/SkGr.cpp - Issue 2113793002: Never allow dither for non-legacy (sRGB or F16) targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGr.cpp

Issue 2113793002: Never allow dither for non-legacy (sRGB or F16) targets. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGr.cpp

diff --git a/src/gpu/SkGr.cpp b/src/gpu/SkGr.cpp

index bb0ef91a889ba773a94ede580a3a4de48c43551d..26947182f81fa1561113641a68f659e22fd62063 100644

--- a/src/gpu/SkGr.cpp

+++ b/src/gpu/SkGr.cpp

@@ -655,7 +655,7 @@ static inline bool skpaint_to_grpaint_impl(GrContext* context,

}

#ifndef SK_IGNORE_GPU_DITHER

- if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0) {

+ if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0 && !allowSRGBInputs) {

jvanverth1 2016/06/30 20:21:37 Does allowSRGBInputs include F16? If so, that seem

grPaint->addColorFragmentProcessor(GrDitherEffect::Make());

}

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »