chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments and rebased. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

diff --git a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

index 6789ef843c40964e68dba5007d05a87df9f9bf73..6d7a73f59e6f89ed7ab6db6b03c24a8c2ef215fa 100644

--- a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

+++ b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

@@ -391,7 +391,7 @@ IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, MAYBE_EndToEnd) {

}

IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, RtpStreamError) {

- ASSERT_TRUE(RunExtensionSubtest("cast_streaming", "rtp_stream_error.html"));

+ ASSERT_FALSE(RunExtensionSubtest("cast_streaming", "rtp_stream_error.html"));

miu 2016/07/06 21:20:26 This doesn't look right. Did you mean to adjust so

xjz 2016/07/06 23:57:39 Done.

}

} // namespace extensions

« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('J')