chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments and rebased. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <stddef.h>	5 #include <stddef.h>

6 #include <stdint.h>	6 #include <stdint.h>

7	7

8 #include <algorithm>	8 #include <algorithm>

9 #include <cmath>	9 #include <cmath>

10 #include <memory>	10 #include <memory>

(...skipping 373 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
384 receiver->AddExpectedColor(YUVColor(41, 240, 110)); // rgb(0, 0, 255)	384 receiver->AddExpectedColor(YUVColor(41, 240, 110)); // rgb(0, 0, 255)

385 receiver->Start();	385 receiver->Start();

386 receiver->WaitForExpectedTonesAndColors();	386 receiver->WaitForExpectedTonesAndColors();

387 receiver->Stop();	387 receiver->Stop();

388	388

389 delete receiver;	389 delete receiver;

390 cast_environment->Shutdown();	390 cast_environment->Shutdown();

391 }	391 }

392	392

393 IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, RtpStreamError) {	393 IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, RtpStreamError) {

394 ASSERT_TRUE(RunExtensionSubtest("cast_streaming", "rtp_stream_error.html"));	394 ASSERT_FALSE(RunExtensionSubtest("cast_streaming", "rtp_stream_error.html"));
	miu 2016/07/06 21:20:26 This doesn't look right. Did you mean to adjust so This doesn't look right. Did you mean to adjust something in the javascript code for this test? xjz 2016/07/06 23:57:39 Done. Show quoted text On 2016/07/06 21:20:26, miu wrote: > This doesn't look right. Did you mean to adjust something in the javascript code > for this test? Done.
395 }	395 }

396	396

397 } // namespace extensions	397 } // namespace extensions

OLD	NEW

« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('J')