media/cast/sender/video_encoder_impl.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/sender/video_encoder_impl.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/sender/fake_software_video_encoder.cc ('K') | « media/cast/sender/video_encoder_impl.h ('k') | media/cast/sender/video_encoder_unittest.cc » ('j') | media/cast/test/cast_benchmarks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/sender/video_encoder_impl.cc

diff --git a/media/cast/sender/video_encoder_impl.cc b/media/cast/sender/video_encoder_impl.cc

index 3a8042b87e69ddec534baca5e98ac2cabb297c03..c0a78e8aba02f61cdebbf584eb5cde3bd4f406f4 100644

--- a/media/cast/sender/video_encoder_impl.cc

+++ b/media/cast/sender/video_encoder_impl.cc

@@ -51,7 +51,7 @@ void EncodeVideoFrameOnEncoderThread(

} // namespace

// static

-bool VideoEncoderImpl::IsSupported(const VideoSenderConfig& video_config) {

+bool VideoEncoderImpl::IsSupported(const FrameSenderConfig& video_config) {

#ifndef OFFICIAL_BUILD

if (video_config.codec == CODEC_VIDEO_FAKE)

return true;

@@ -61,7 +61,7 @@ bool VideoEncoderImpl::IsSupported(const VideoSenderConfig& video_config) {

VideoEncoderImpl::VideoEncoderImpl(

scoped_refptr<CastEnvironment> cast_environment,

- const VideoSenderConfig& video_config,

+ const FrameSenderConfig& video_config,

const StatusChangeCallback& status_change_cb)

: cast_environment_(cast_environment) {

CHECK(cast_environment_->HasVideoThread());

@@ -83,7 +83,7 @@ VideoEncoderImpl::VideoEncoderImpl(

}

dynamic_config_.key_frame_requested = false;

- dynamic_config_.bit_rate = video_config.start_bitrate;

+ dynamic_config_.bit_rate = video_config.codec_specific_params.start_bitrate;

cast_environment_->PostTask(

CastEnvironment::MAIN,