media/cast/sender/fake_software_video_encoder.cc - Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/sender/fake_software_video_encoder.cc

Issue 2113783002: Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/sender/fake_software_video_encoder.h ('K') | « media/cast/sender/fake_software_video_encoder.h ('k') | media/cast/sender/h264_vt_encoder.h » ('j') | media/cast/test/cast_benchmarks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/sender/fake_software_video_encoder.cc

diff --git a/media/cast/sender/fake_software_video_encoder.cc b/media/cast/sender/fake_software_video_encoder.cc

index 3a304f6a2b14932f8ffbaf5768593c0c0efed336..ddda9e8ce362853620c531ea2aa8cab6f109dd3a 100644

--- a/media/cast/sender/fake_software_video_encoder.cc

+++ b/media/cast/sender/fake_software_video_encoder.cc

@@ -18,7 +18,7 @@ namespace media {

namespace cast {

FakeSoftwareVideoEncoder::FakeSoftwareVideoEncoder(

- const VideoSenderConfig& video_config)

+ const FrameSenderConfig& video_config)

: video_config_(video_config),

next_frame_is_key_(true),

frame_id_(FrameId::first()),

@@ -72,6 +72,7 @@ void FakeSoftwareVideoEncoder::Encode(

}

void FakeSoftwareVideoEncoder::UpdateRates(uint32_t new_bitrate) {

+ DCHECK_GT(video_config_.max_frame_rate, 0);

miu 2016/06/30 21:59:43 Seems that this could be in the ctor (to just chec

xjz 2016/07/01 23:52:09 Done.

frame_size_ = new_bitrate / video_config_.max_frame_rate / 8;

}