Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: last comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index faaa9cee916aad8cf2c0b47085abde272c1025ce..36d4b34d5e21e6d624c3376508500f1f970147f6 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -275,14 +275,13 @@ class PasswordFormManager : public PasswordStoreConsumer {
private:
// ManagerAction - What does the manager do with this form? Either it
// fills it, or it doesn't. If it doesn't fill it, that's either
- // because it has no match, or it is blacklisted, or it is disabled
- // via the AUTOCOMPLETE=off attribute. Note that if we don't have
- // an exact match, we still provide candidates that the user may
- // end up choosing.
+ // because it has no match or it is disabled via the AUTOCOMPLETE=off
+ // attribute. Note that if we don't have an exact match, we still provide
+ // candidates that the user may end up choosing.
enum ManagerAction {
kManagerActionNone = 0,
kManagerActionAutofilled,
- kManagerActionBlacklisted,
+ kManagerActionBlacklisted_Obsolete,
kManagerActionMax
};
@@ -462,6 +461,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Send appropriate votes based on what is currently being saved.
void SendVotesOnSave();
+ // Sets |user_action_| and records some metrics.
+ void SetUserAction(UserAction user_action);
+
// Edits some fields in |pending_credentials_| before it can be used to
// update the password store. It also goes through |not_best_matches|,
// updates the password of those which share the old password and username

Powered by Google App Engine
This is Rietveld 408576698