components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 2113743002: Add instrumentation for password autofill and Credential Manager API user flows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: last comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index dc995b0ad2a013c860242e2081edc6c6166207f9..9a9c48dbdb58c029c8f6001c76d69fc007229d6e 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -7,6 +7,7 @@

#include <algorithm>

#include <utility>

+#include "base/metrics/user_metrics.h"

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/affiliated_match_helper.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

@@ -145,6 +146,7 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

: CredentialType::CREDENTIAL_TYPE_FEDERATED);

delegate_->client()->NotifyUserAutoSignin(std::move(local_results),

origin_);

+ base::RecordAction(base::UserMetricsAction("CredentialManager_Autosignin"));

delegate_->SendCredential(send_callback_, info);

return;

}