Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issue 211373009: Fix a crash caused by track insertion after load(). (Closed)

Created:
6 years, 9 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Fix a crash caused by track insertion after load(). This patch fixes a crash caused by stale LoadMediaResource flag in m_pendingActionFlags when load() is explicitly called on a media element. The insertion of a <track> element triggers the crash by triggering the scheduling of the m_loadTimer, which ends up using the stale flag data when the timer fires. The fix is to clear the LoadMediaResource flag from m_pendingActionFlags when a new load is initiated. BUG=356352 TEST=LayoutTests/media/track/track-insert-after-load-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170003

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
A LayoutTests/media/track/track-insert-after-load-crash.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/media/track/track-insert-after-load-crash-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/211373009/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/211373009/diff/1/Source/core/html/HTMLMediaElement.cpp#newcode609 Source/core/html/HTMLMediaElement.cpp:609: // FIXME: Figure out appropriate place to reset LoadTextTrackResource ...
6 years, 9 months ago (2014-03-26 01:13:30 UTC) #1
acolwell GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-26 01:15:52 UTC) #2
adamk
lgtm
6 years, 9 months ago (2014-03-26 01:25:26 UTC) #3
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-26 01:28:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/211373009/1
6 years, 9 months ago (2014-03-26 01:28:36 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 02:14:43 UTC) #6
Message was sent while issue was closed.
Change committed as 170003

Powered by Google App Engine
This is Rietveld 408576698