Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 211363003: Add UseCounters for NamedNodeMap functions (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
Reviewers:
eseidel
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add UseCounters for NamedNodeMap functions This is in order to help determine which of these need to be kept in the DOM spec, since it looks like some of them will be needed: https://www.w3.org/Bugs/Public/show_bug.cgi?id=21986 BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M Source/core/dom/NamedNodeMap.idl View 1 chunk +9 lines, -10 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-25 17:25:21 UTC) #1
eseidel
lgtm Great.
6 years, 9 months ago (2014-03-25 17:48:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/211363003/1
6 years, 9 months ago (2014-03-25 17:48:14 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 18:10:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 18:10:00 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 18:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/211363003/1
6 years, 9 months ago (2014-03-25 18:16:19 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 18:16:35 UTC) #8
Message was sent while issue was closed.
Change committed as 169969

Powered by Google App Engine
This is Rietveld 408576698