Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.

Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ )

Reason for revert:
Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/

Original issue's description:
> Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
>
> The spec was modified to relax some requirements which implementors had not been
> enforcing. Part of this process involved introducing a new abstract operation
> ToIndex, which had partial overlap with our existing semantics as well as some
> differences (most notably treating undefined as 0). Test262 tests were introduced to
> check for the new semantics, some of which we were failing. This patch amends the
> parts of our implementation corresponding to specification algorithms which use
> ToIndex to follow its semantics precisely.
>
> BUG=v8:4784, v8:5120
>
> Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> Cr-Commit-Position: refs/heads/master@{#37406}

TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4784, v8:5120
Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f
Cr-Commit-Position: refs/heads/master@{#37417}

[Michael Hablich, 2016-06-30 07:31:30]

The CQ bit was checked by hablich@chromium.org

[Michael Hablich, 2016-06-30 07:31:31]

Created Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use
ToIndex.

[commit-bot: I haz the power, 2016-06-30 07:31:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 07:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 07:31:53]

Failed to apply patch for test/test262/test262.status:
While running git apply --index -3 -p1;
  error: patch failed: test/test262/test262.status:510
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: test/test262/test262.status: patch does not apply

Patch:       test/test262/test262.status
Index: test/test262/test262.status
diff --git a/test/test262/test262.status b/test/test262/test262.status
index
d25d23f19c3f6f9e8c319e9077d3b4b777c0d1b0..b17e6532dc491cf985e0ffe1a5ab04118cada545
100644
--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -371,6 +371,34 @@
   'annexB/built-ins/Object/prototype/__lookupGetter__/this-non-obj': [FAIL],
   'annexB/built-ins/Object/prototype/__lookupSetter__/this-non-obj': [FAIL],
 
+  # https://bugs.chromium.org/p/v8/issues/detail?id=5120
+  'built-ins/DataView/negative-bytelength-throws': [FAIL],
+  'built-ins/DataView/prototype/getFloat32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getFloat64/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getInt16/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getInt32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getInt8/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getUint16/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getUint32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/getUint8/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setFloat32/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setFloat32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setFloat64/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setFloat64/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setInt16/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setInt16/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setInt32/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setInt32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setInt8/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setInt8/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setUint16/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setUint16/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setUint32/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setUint32/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/prototype/setUint8/no-value-arg': [FAIL],
+  'built-ins/DataView/prototype/setUint8/toindex-byteoffset': [FAIL],
+  'built-ins/DataView/toindex-byteoffset': [FAIL],
+
   # https://bugs.chromium.org/p/v8/issues/detail?id=5121
   'language/expressions/assignment/destructuring/obj-prop-__proto__dup':
[FAIL],
 
@@ -510,20 +538,6 @@
   # https://github.com/tc39/test262/issues/694
  
'language/statements/class/subclass/builtin-objects/ArrayBuffer/regular-subclassing':
[FAIL],
 
-  # https://github.com/tc39/test262/issues/685
-  'built-ins/DataView/prototype/setUint8/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setUint16/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setUint32/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setInt8/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setInt16/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setInt32/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setFloat32/range-check-after-value-conversion':
[FAIL],
-  'built-ins/DataView/prototype/setFloat64/range-check-after-value-conversion':
[FAIL],
-
-  # https://github.com/tc39/test262/issues/686
-  'built-ins/DataView/prototype/setFloat32/toindex-byteoffset': [FAIL],
-  'built-ins/DataView/prototype/setFloat64/toindex-byteoffset': [FAIL],
-
   ############################ SKIPPED TESTS #############################
 
   # These tests take a looong time to run.

[Michael Hablich, 2016-06-30 07:36:29]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-06-30 07:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 07:36:55]

Committed patchset #2 (id:170001)

[commit-bot: I haz the power, 2016-06-30 07:39:22]

Description was changed from

==========
Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
(patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ )

Reason for revert:
Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/

Original issue's description:
> Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
> 
> The spec was modified to relax some requirements which implementors had not
been
> enforcing. Part of this process involved introducing a new abstract operation
> ToIndex, which had partial overlap with our existing semantics as well as some
> differences (most notably treating undefined as 0). Test262 tests were
introduced to
> check for the new semantics, some of which we were failing. This patch amends
the
> parts of our implementation corresponding to specification algorithms which
use
> ToIndex to follow its semantics precisely.
> 
> BUG=v8:4784,v8:5120
> 
> Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> Cr-Commit-Position: refs/heads/master@{#37406}

TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4784,v8:5120
==========

to

==========
Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
(patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ )

Reason for revert:
Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/

Original issue's description:
> Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
>
> The spec was modified to relax some requirements which implementors had not
been
> enforcing. Part of this process involved introducing a new abstract operation
> ToIndex, which had partial overlap with our existing semantics as well as some
> differences (most notably treating undefined as 0). Test262 tests were
introduced to
> check for the new semantics, some of which we were failing. This patch amends
the
> parts of our implementation corresponding to specification algorithms which
use
> ToIndex to follow its semantics precisely.
>
> BUG=v8:4784,v8:5120
>
> Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> Cr-Commit-Position: refs/heads/master@{#37406}

TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4784,v8:5120

Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f
Cr-Commit-Position: refs/heads/master@{#37417}
==========

[commit-bot: I haz the power, 2016-06-30 07:39:23]

Patchset 2 (id:??) landed as
https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f
Cr-Commit-Position: refs/heads/master@{#37417}

[bakkot, 2016-08-16 17:20:07]

A revert of this CL (patchset #2 id:170001) has been created in
https://codereview.chromium.org/2247073004/ by bakkot@google.com.

The reason for reverting is: WebGL tests have been updated and rolled (at
https://codereview.chromium.org/2227023002), so this should no longer fail
outdated tests..