Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2113583002:
[gn] Switch custom snapsot bot to gn (Closed)
|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Switch custom snapsot bot to gn
BUG=chromium:474921
NOTRY=true
Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193
Committed: https://crrev.com/e8d2238d241ca2400fd5038c6b08ca4ab85f761a
Cr-Original-Commit-Position: refs/heads/master@{#37431}
Cr-Commit-Position: refs/heads/master@{#37436}
Patch Set 1 #Patch Set 2 : Doh #Patch Set 3 : Fix and rebase #Messages
Total messages: 24 (13 generated)
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG= ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org, yangguo@chromium.org
PTAL Locally tested: gn gen out/Release --args='is_debug=false v8_embed_script="test/mjsunit/mjsunit.js"' ninja -j1000 -C out/Release d8 tools/run-tests.py --arch x64 --mode Release --buildbot mjsunit --no-variants --no-harness
On 2016/06/30 07:15:55, Michael Achenbach wrote: > PTAL > > Locally tested: > gn gen out/Release --args='is_debug=false > v8_embed_script="test/mjsunit/mjsunit.js"' > ninja -j1000 -C out/Release d8 > tools/run-tests.py --arch x64 --mode Release --buildbot mjsunit --no-variants > --no-harness lgtm.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18520)
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2113583002/#ps20001 (title: "Doh")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2107423003/ by machenbach@chromium.org. The reason for reverting is: Breaks....
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ==========
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2113583002/#ps40001 (title: "Fix and rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Cr-Commit-Position: refs/heads/master@{#37431} ========== to ========== [gn] Switch custom snapsot bot to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193 Committed: https://crrev.com/e8d2238d241ca2400fd5038c6b08ca4ab85f761a Cr-Original-Commit-Position: refs/heads/master@{#37431} Cr-Commit-Position: refs/heads/master@{#37436} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e8d2238d241ca2400fd5038c6b08ca4ab85f761a Cr-Commit-Position: refs/heads/master@{#37436} |
