Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: infra/mb/mb_config.pyl

Issue 2113583002: [gn] Switch custom snapsot bot to gn (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix and rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/mb/mb_config.pyl
diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl
index fa4da999f8ec7d95e4b08a50fae9f63181a8d8f4..28bb1c168073f3503031d776bb68848f4c23ee65 100644
--- a/infra/mb/mb_config.pyl
+++ b/infra/mb/mb_config.pyl
@@ -27,7 +27,7 @@
# Linux64.
'V8 Linux64 - builder': 'gn_release_x64',
'V8 Linux64 - debug builder': 'gn_debug_x64_valgrind',
- 'V8 Linux64 - custom snapshot - debug builder': 'gyp_debug_x64_custom',
+ 'V8 Linux64 - custom snapshot - debug builder': 'gn_debug_x64_custom',
'V8 Linux64 - internal snapshot': 'gn_release_x64_internal',
# Windows.
'V8 Win32 - builder': 'gyp_release_x86_minimal_symbols',
@@ -186,6 +186,8 @@
'gn', 'release_trybot', 'x64', 'swarming'],
# GN debug configs for x64.
+ 'gn_debug_x64_custom': [
+ 'gn', 'debug_bot', 'x64', 'swarming', 'v8_snapshot_custom'],
'gn_debug_x64_trybot': [
'gn', 'debug_trybot', 'x64', 'swarming'],
'gn_debug_x64_valgrind': [
@@ -216,8 +218,6 @@
'gyp', 'debug_bot', 'x64', 'swarming'],
'gyp_debug_x64_asan_edge': [
'gyp', 'debug_bot', 'x64', 'asan', 'lsan', 'edge'],
- 'gyp_debug_x64_custom': [
- 'gyp', 'debug_bot', 'x64', 'swarming', 'v8_snapshot_custom'],
'gyp_debug_x64_minimal_symbols': [
'gyp', 'debug_bot', 'x64', 'minimal_symbols', 'swarming'],
@@ -589,8 +589,10 @@
},
'v8_snapshot_custom': {
- # TODO(machenbach): Add this to gn.
- # Path needs to be relative to src/v8.gyp.
+ # GN path is relative to project root.
+ 'gn_args': 'v8_embed_script="test/mjsunit/mjsunit.js"',
+
+ # Gyp path is relative to src/v8.gyp.
'gyp_defines': 'embed_script=../test/mjsunit/mjsunit.js',
},
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698