More detailed implementation of the RequestPicker

components/offline_pages/background/device_conditions.h

Index: components/offline_pages/background/device_conditions.h
diff --git a/components/offline_pages/background/device_conditions.h b/components/offline_pages/background/device_conditions.h
index e26c7d1289b0c57b9fab74b29522379ee57a11c2..13366a7cd7073bc8e489d6b4384d1f828fc04baf 100644
--- a/components/offline_pages/background/device_conditions.h
+++ b/components/offline_pages/background/device_conditions.h
@@ -20,6 +20,15 @@ class DeviceConditions {
         battery_percentage_(battery_percentage),
         net_connection_type_(net_connection_type) {}
 
+  DeviceConditions()
+      : power_connected_(true), battery_percentage_(75),
+        net_connection_type_(net::NetworkChangeNotifier::CONNECTION_WIFI) {}
+
+  DeviceConditions(const DeviceConditions& other)

[fgorski, 2016/07/20 16:23:30]

Given that you are defining the copy constructor, what are your thought on
assignment operator?

[fgorski, 2016/07/21 17:01:20]

I think you missed this one.

[Pete Williamson, 2016/07/21 19:48:45]

Ah, right, sorry.  I intentionally left the assignment operator out because it
caused an error trying to assign to a const variable in the assignment operator
(it is OK for a constructor to assign to a const member variable, but not for an
assignment operator).  Yes, I know the rule that you should provide both when
you have either, but since it didn't compile, I thought I'd try just the copy
ctor.

Thinking about it a bit more, I can rely on the default, and just not add the
"no copy ctor or assignment operator" macro, and I should be fine, so the latest
has the copy ctor removed, and a comment added.

+      : power_connected_(other.power_connected_),
+      battery_percentage_(other.battery_percentage_),

[fgorski, 2016/07/20 16:23:31]

nit: please align properly

[Pete Williamson, 2016/07/20 19:50:43]

Done.

+      net_connection_type_(other.net_connection_type_) {}
+
   // Returns whether power is connected.
   bool IsPowerConnected() const { return power_connected_; }