More detailed implementation of the RequestPicker

components/offline_pages/background/device_conditions.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_DEVICE_CONDITIONS_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_DEVICE_CONDITIONS_H_
 
 #include "net/base/network_change_notifier.h"
 
 namespace offline_pages {
 
 // Device network and power conditions.
 class DeviceConditions {
  public:
   DeviceConditions(
       bool power_connected,
       int battery_percentage,
       net::NetworkChangeNotifier::ConnectionType net_connection_type)
       : power_connected_(power_connected),
         battery_percentage_(battery_percentage),
         net_connection_type_(net_connection_type) {}
 
+  DeviceConditions()
+      : power_connected_(true), battery_percentage_(75),
+        net_connection_type_(net::NetworkChangeNotifier::CONNECTION_WIFI) {}
+
+  DeviceConditions(const DeviceConditions& other)

[fgorski, 2016/07/20 16:23:30]

Given that you are defining the copy constructor, what are your thought on
assignment operator?

[fgorski, 2016/07/21 17:01:20]

I think you missed this one.

[Pete Williamson, 2016/07/21 19:48:45]

Ah, right, sorry.  I intentionally left the assignment operator out because it
caused an error trying to assign to a const variable in the assignment operator
(it is OK for a constructor to assign to a const member variable, but not for an
assignment operator).  Yes, I know the rule that you should provide both when
you have either, but since it didn't compile, I thought I'd try just the copy
ctor.

Thinking about it a bit more, I can rely on the default, and just not add the
"no copy ctor or assignment operator" macro, and I should be fine, so the latest
has the copy ctor removed, and a comment added.

+      : power_connected_(other.power_connected_),
+      battery_percentage_(other.battery_percentage_),

[fgorski, 2016/07/20 16:23:31]

nit: please align properly

[Pete Williamson, 2016/07/20 19:50:43]

Done.

+      net_connection_type_(other.net_connection_type_) {}
+
   // Returns whether power is connected.
   bool IsPowerConnected() const { return power_connected_; }
 
   // Returns percentage of remaining battery power (0-100).
   int GetBatteryPercentage() const { return battery_percentage_; }
 
   // Returns the current type of network connection, if any.
   net::NetworkChangeNotifier::ConnectionType GetNetConnectionType() const {
     return net_connection_type_;
   }
 
  private:
   const bool power_connected_;
   const int battery_percentage_;
   const net::NetworkChangeNotifier::ConnectionType net_connection_type_;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_DEVICE_CONDITIONS_H_