chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 2113383002: More detailed implementation of the RequestPicker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2113383002: More detailed implementation of the RequestPicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify picker logic for multiple criteria Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index 66d4416e2e2feb425c2c42b29c2498112e869f8b..64c133c1e9c5ba8588b645fe8ff5f62bde0cfd52 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -41,6 +41,7 @@ namespace android {

namespace {

const char kOfflinePageBridgeKey[] = "offline-page-bridge";

+const bool kUserRequested = true;

void ToJavaOfflinePageList(JNIEnv* env,

jobject j_result_obj,

@@ -366,7 +367,7 @@ void OfflinePageBridge::SavePageLater(

GetForBrowserContext(browser_context_);

coordinator->SavePageLater(

- GURL(ConvertJavaStringToUTF8(env, j_url)), client_id);

+ GURL(ConvertJavaStringToUTF8(env, j_url)), client_id, kUserRequested);

}

void OfflinePageBridge::DeletePages(