QUIC - added force_hol_blocking field trial param to enable forced HOL blocking.

QUIC - added force_hol_blocking field trial param to enable forced HOL blocking.

R=rch@chromium.org
BUG=

Committed: https://crrev.com/da193a8f519a8987776be3355360611d06ebc797
Cr-Commit-Position: refs/heads/master@{#404546}

[Ryan Hamilton, 2016-07-01 21:32:27]

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
File components/network_session_configurator/network_session_configurator.cc
(right):

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:273:
GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
Can you add a test in network_session_configurator_unittest.cc?

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:275: 
nit: blank line

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1682: config.SetForceHolBlocking();
Can we add a test to quic_stream_factory_test that the created sessions' config
has this set?

We should probably also have a test in quic_network_transaction_tests which
shows this happening. Probably a post body?

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1683: }
nit: no {}s on 1-line ifs in net/ code.

[Buck, 2016-07-08 22:17:09]

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
File components/network_session_configurator/network_session_configurator.cc
(right):

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:273:
GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
On 2016/07/01 21:32:26, Ryan Hamilton wrote:
> Can you add a test in network_session_configurator_unittest.cc?

Done.

https://codereview.chromium.org/2113343002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:275: 
On 2016/07/01 21:32:27, Ryan Hamilton wrote:
> nit: blank line

Done.

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1682: config.SetForceHolBlocking();
On 2016/07/01 21:32:27, Ryan Hamilton wrote:
> Can we add a test to quic_stream_factory_test that the created sessions'
config
> has this set?
> 
> We should probably also have a test in quic_network_transaction_tests which
> shows this happening. Probably a post body?

Done.

https://codereview.chromium.org/2113343002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1683: }
On 2016/07/01 21:32:27, Ryan Hamilton wrote:
> nit: no {}s on 1-line ifs in net/ code.

Done.

[Ryan Hamilton, 2016-07-08 22:38:07]

lgtm

[Buck, 2016-07-08 22:52:22]

The CQ bit was checked by ckrasic@chromium.org

[commit-bot: I haz the power, 2016-07-08 22:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 00:39:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-09 00:42:52]

Description was changed from

==========
QUIC - added force_hol_blocking field trial param to enable forced HOL blocking.

R=rch@chromium.org
BUG=
==========

to

==========
QUIC - added force_hol_blocking field trial param to enable forced HOL blocking.

R=rch@chromium.org
BUG=

Committed: https://crrev.com/da193a8f519a8987776be3355360611d06ebc797
Cr-Commit-Position: refs/heads/master@{#404546}
==========

[commit-bot: I haz the power, 2016-07-09 00:42:53]

Patchset 2 (id:??) landed as
https://crrev.com/da193a8f519a8987776be3355360611d06ebc797
Cr-Commit-Position: refs/heads/master@{#404546}