Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2113343002: QUIC - added force_hol_blocking field trial param to enable forced HOL blocking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@126418608
Patch Set: review feedback round #1 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/network_session_configurator/network_session_configurator.h " 5 #include "components/network_session_configurator/network_session_configurator.h "
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 bool ShouldQuicDisableDiskCache(const VariationParameters& quic_trial_params) { 196 bool ShouldQuicDisableDiskCache(const VariationParameters& quic_trial_params) {
197 return base::LowerCaseEqualsASCII( 197 return base::LowerCaseEqualsASCII(
198 GetVariationParam(quic_trial_params, "disable_disk_cache"), "true"); 198 GetVariationParam(quic_trial_params, "disable_disk_cache"), "true");
199 } 199 }
200 200
201 bool ShouldQuicPreferAes(const VariationParameters& quic_trial_params) { 201 bool ShouldQuicPreferAes(const VariationParameters& quic_trial_params) {
202 return base::LowerCaseEqualsASCII( 202 return base::LowerCaseEqualsASCII(
203 GetVariationParam(quic_trial_params, "prefer_aes"), "true"); 203 GetVariationParam(quic_trial_params, "prefer_aes"), "true");
204 } 204 }
205 205
206 bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
207 return base::LowerCaseEqualsASCII(
208 GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
209 }
210
206 int GetQuicMaxNumberOfLossyConnections( 211 int GetQuicMaxNumberOfLossyConnections(
207 const VariationParameters& quic_trial_params) { 212 const VariationParameters& quic_trial_params) {
208 int value; 213 int value;
209 if (base::StringToInt(GetVariationParam(quic_trial_params, 214 if (base::StringToInt(GetVariationParam(quic_trial_params,
210 "max_number_of_lossy_connections"), 215 "max_number_of_lossy_connections"),
211 &value)) { 216 &value)) {
212 return value; 217 return value;
213 } 218 }
214 return 0; 219 return 0;
215 } 220 }
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 params->quic_load_server_info_timeout_srtt_multiplier = 374 params->quic_load_server_info_timeout_srtt_multiplier =
370 load_server_info_timeout_srtt_multiplier; 375 load_server_info_timeout_srtt_multiplier;
371 } 376 }
372 params->quic_enable_connection_racing = 377 params->quic_enable_connection_racing =
373 ShouldQuicEnableConnectionRacing(quic_trial_params); 378 ShouldQuicEnableConnectionRacing(quic_trial_params);
374 params->quic_enable_non_blocking_io = 379 params->quic_enable_non_blocking_io =
375 ShouldQuicEnableNonBlockingIO(quic_trial_params); 380 ShouldQuicEnableNonBlockingIO(quic_trial_params);
376 params->quic_disable_disk_cache = 381 params->quic_disable_disk_cache =
377 ShouldQuicDisableDiskCache(quic_trial_params); 382 ShouldQuicDisableDiskCache(quic_trial_params);
378 params->quic_prefer_aes = ShouldQuicPreferAes(quic_trial_params); 383 params->quic_prefer_aes = ShouldQuicPreferAes(quic_trial_params);
384 params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
379 int max_number_of_lossy_connections = 385 int max_number_of_lossy_connections =
380 GetQuicMaxNumberOfLossyConnections(quic_trial_params); 386 GetQuicMaxNumberOfLossyConnections(quic_trial_params);
381 if (max_number_of_lossy_connections != 0) { 387 if (max_number_of_lossy_connections != 0) {
382 params->quic_max_number_of_lossy_connections = 388 params->quic_max_number_of_lossy_connections =
383 max_number_of_lossy_connections; 389 max_number_of_lossy_connections;
384 } 390 }
385 float packet_loss_threshold = GetQuicPacketLossThreshold(quic_trial_params); 391 float packet_loss_threshold = GetQuicPacketLossThreshold(quic_trial_params);
386 if (packet_loss_threshold != 0) 392 if (packet_loss_threshold != 0)
387 params->quic_packet_loss_threshold = packet_loss_threshold; 393 params->quic_packet_loss_threshold = packet_loss_threshold;
388 params->enable_quic_port_selection = 394 params->enable_quic_port_selection =
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 void ParseFieldTrialsAndCommandLine(bool is_quic_allowed_by_policy, 499 void ParseFieldTrialsAndCommandLine(bool is_quic_allowed_by_policy,
494 const std::string& quic_user_agent_id, 500 const std::string& quic_user_agent_id,
495 net::HttpNetworkSession::Params* params) { 501 net::HttpNetworkSession::Params* params) {
496 const base::CommandLine& command_line = 502 const base::CommandLine& command_line =
497 *base::CommandLine::ForCurrentProcess(); 503 *base::CommandLine::ForCurrentProcess();
498 ParseFieldTrialsAndCommandLineInternal( 504 ParseFieldTrialsAndCommandLineInternal(
499 command_line, is_quic_allowed_by_policy, quic_user_agent_id, params); 505 command_line, is_quic_allowed_by_policy, quic_user_agent_id, params);
500 } 506 }
501 507
502 } // namespace network_session_configurator 508 } // namespace network_session_configurator
OLDNEW
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698