media/renderers/skcanvas_video_renderer.cc - Issue 2113243003: media: Introduce Y8 and Y16 video pixel format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/skcanvas_video_renderer.cc

Issue 2113243003: media: Introduce Y8 and Y16 video pixel format (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase to land Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/renderers/skcanvas_video_renderer.cc

diff --git a/media/renderers/skcanvas_video_renderer.cc b/media/renderers/skcanvas_video_renderer.cc

index 2210a98f816df7b9e23090929c44f7414b761314..5b20c2431506843fc699521a176e73933fc0e681 100644

--- a/media/renderers/skcanvas_video_renderer.cc

+++ b/media/renderers/skcanvas_video_renderer.cc

@@ -642,6 +642,12 @@ void SkCanvasVideoRenderer::ConvertVideoFrameToRGBPixels(

case PIXEL_FORMAT_RGB32:

case PIXEL_FORMAT_MJPEG:

case PIXEL_FORMAT_MT21:

+ // TODO(dshwang): Use either I400ToARGB or J400ToARGB depending if we want

+ // BT.601 constrained range of 16 to 240, or JPEG full range BT.601

+ // coefficients. Implement it when Y8/16 foramt is supported.

+ // crbug.com/624436

+ case PIXEL_FORMAT_Y8:

+ case PIXEL_FORMAT_Y16:

case PIXEL_FORMAT_UNKNOWN:

NOTREACHED();

}