media: Introduce Y8 and Y16 video pixel format

media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/ea1ddc4e14b1b51a8dcbc29cabcec6513127e0c9
Cr-Commit-Position: refs/heads/master@{#421804}

[dshwang, 2016-07-01 12:19:50]

dongseong.hwang@intel.com changed reviewers:
+ aleksandar.stojiljkovic@intel.com, dcastagna@chromium.org,
dnicoara@chromium.org

[dshwang, 2016-07-01 12:19:51]

dnicoara@, could you review?

It's initial patch for support 8bit and 16bit video stream.

Y8 name is after UVC fourcc, as Y means luma;
https://github.com/torvalds/linux/blob/master/include/uapi/linux/videodev2.h#...

Depth 16bit stream will use Y16. Y16 can be used for other cases also.
What do you think? specific Z16 is better than unified Y16?
FYI, UVC fourcc has both Z16 and Y16. I think Y16 is enough.

[dshwang, 2016-07-01 14:12:58]

Description was changed from

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
==========

to

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[dshwang, 2016-07-01 14:27:43]

Patchset #2 (id:20001) has been deleted

[dshwang, 2016-07-01 15:05:08]

Patchset #2 (id:40001) has been deleted

[dnicoara, 2016-07-04 14:14:07]

dnicoara@chromium.org changed reviewers:
+ hubbe@chromium.org

[dnicoara, 2016-07-04 14:14:08]

+ hubbe@ since he is an owner over some of these files.

I think these are fine, but I'd defer to owners, and kbr@'s reviews since they
have a better view on the requirements.

[dshwang, 2016-07-04 14:51:09]

Description was changed from

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[dshwang, 2016-07-04 14:51:09]

dongseong.hwang@intel.com changed reviewers:
+ kbr@chromium.org

[dshwang, 2016-07-04 14:55:05]

On 2016/07/04 14:14:08, dnicoara wrote:
> + hubbe@ since he is an owner over some of these files.
> 
> I think these are fine, but I'd defer to owners, and kbr@'s reviews since they
> have a better view on the requirements.

Thank you for reviewing.

hubbe@, kbr@, could you review?

Y8 will use R8 texture. Y16 will use RG8 texture as RG8 is used in
https://codereview.chromium.org/2122573003/
Rationale to choose RG8, instead of R16
1. GpuMemoryBuffer cannot support R16. (e.g. Mesa supports R8 and GR88 dmabuf)
2. GL_EXT_texture_rg is more widely used than GL_EXT_color_buffer_half_float
(e.g. Mesa v11.2 supports only GL_EXT_texture_rg)

I want to discuss about RG8 and R16 in crbug.com/624436 if you don't agree on
the direction.

[dshwang, 2016-07-04 14:55:17]

Patchset #2 (id:60001) has been deleted

[fbarchard1, 2016-07-05 18:03:17]

fbarchard@google.com changed reviewers:
+ fbarchard@google.com

[fbarchard1, 2016-07-05 18:03:17]

lgtm

[dshwang, 2016-07-06 10:30:36]

On 2016/07/05 18:03:17, fbarchard1 wrote:
> lgtm

Thank you for reviewing!

hubbe@, kbr@, could you review?

[hubbe, 2016-07-06 17:39:00]

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
The code below doesn't support bits_per_channel higher than 10.
Thus, this will not work unless you fix the convert-to-half-float code below.

[dshwang, 2016-07-06 17:45:18]

Thank you for reviewing.

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
On 2016/07/06 17:39:00, hubbe wrote:
> The code below doesn't support bits_per_channel higher than 10.
> Thus, this will not work unless you fix the convert-to-half-float code below.

yes, I know. It will be handled in the next CL;
https://codereview.chromium.org/2122573003/

[Ken Russell (switch to Gerrit), 2016-07-06 18:24:42]

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
On 2016/07/06 17:45:18, dshwang wrote:
> On 2016/07/06 17:39:00, hubbe wrote:
> > The code below doesn't support bits_per_channel higher than 10.
> > Thus, this will not work unless you fix the convert-to-half-float code
below.
> 
> yes, I know. It will be handled in the next CL;
> https://codereview.chromium.org/2122573003/

Is it wise to land this patch without the next CL? While the other CL is huge,
breaking the code temporarily doesn't seem to me a good path to take.

[dshwang, 2016-07-07 12:41:08]

Thank you for reviewing!

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
On 2016/07/06 18:24:42, Ken Russell wrote:
> On 2016/07/06 17:45:18, dshwang wrote:
> > On 2016/07/06 17:39:00, hubbe wrote:
> > > The code below doesn't support bits_per_channel higher than 10.
> > > Thus, this will not work unless you fix the convert-to-half-float code
> below.
> > 
> > yes, I know. It will be handled in the next CL;
> > https://codereview.chromium.org/2122573003/
> 
> Is it wise to land this patch without the next CL? While the other CL is huge,
> breaking the code temporarily doesn't seem to me a good path to take.

It doesn't break any code, because any video decoders don't use Y16 yet. This
line is added to avoid build failure.

Next CL has concern about R16 vs. RB8, but this CL will be intact, no matter
what decision happens.

IMO, it's good to land.

[hubbe, 2016-07-07 17:51:39]

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
On 2016/07/07 12:41:08, dshwang wrote:
> On 2016/07/06 18:24:42, Ken Russell wrote:
> > On 2016/07/06 17:45:18, dshwang wrote:
> > > On 2016/07/06 17:39:00, hubbe wrote:
> > > > The code below doesn't support bits_per_channel higher than 10.
> > > > Thus, this will not work unless you fix the convert-to-half-float code
> > below.
> > > 
> > > yes, I know. It will be handled in the next CL;
> > > https://codereview.chromium.org/2122573003/
> > 
> > Is it wise to land this patch without the next CL? While the other CL is
huge,
> > breaking the code temporarily doesn't seem to me a good path to take.
> 
> It doesn't break any code, because any video decoders don't use Y16 yet. This
> line is added to avoid build failure.
> 
> Next CL has concern about R16 vs. RB8, but this CL will be intact, no matter
> what decision happens.
> 
> IMO, it's good to land.

You need to do the proper error handling.
Always assume that your next CL is going to land a long time from now and
someone else might try to use or change your code in between.

[dshwang, 2016-07-07 18:11:38]

Could you review agian? Thank you.

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/80001/cc/resources/video_reso...
cc/resources/video_resource_updater.cc:288: case media::PIXEL_FORMAT_Y16:
On 2016/07/07 17:51:39, hubbe wrote:
> You need to do the proper error handling.
> Always assume that your next CL is going to land a long time from now and
> someone else might try to use or change your code in between.

Ok, I understand. Done.

https://codereview.chromium.org/2113243003/diff/100001/cc/resources/video_res...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/100001/cc/resources/video_res...
cc/resources/video_resource_updater.cc:297: }
Add error handling code.

[inactive_dshwang_plz_cc_intel, 2016-09-20 14:57:12]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:57:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:57:39]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[inactive_dshwang_plz_cc_intel, 2016-09-20 15:04:57]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:05:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:05:30]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[hubbe, 2016-09-20 17:06:56]

non-owner LGTM

[fbarchard1, 2016-09-20 21:52:24]

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types.h
File media/base/video_types.h (right):

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types...
media/base/video_types.h:56: PIXEL_FORMAT_Y8 = 22,   // single 8bpp plane.
// Single 8 bpp plane.

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types...
media/base/video_types.h:57: PIXEL_FORMAT_Y16 = 23,  // single 16bpp plane.
// Single 16 bpp plane.

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
media/renderers/skcanvas_video_renderer.cc:613: case PIXEL_FORMAT_Y8:
Y8 is supported by libyuv if you want to add the converter to ARGB.
Use either I400ToARGB or J400ToARGB depending if you want bt601 constrained
range of 16 to 240, or JPeg full range 601 coefficients.

[dshwang, 2016-09-21 08:55:34]

The CQ bit was checked by dongseong.hwang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 08:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 08:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 08:55:46]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[dshwang, 2016-09-21 08:59:59]

dongseong.hwang@intel.com changed reviewers:
+ cpu@chromium.org, danakj@chromium.org, mkwst@chromium.org

[dshwang, 2016-09-21 09:00:00]

Thank you for reviewing. resolved concerns.

danakj@, could you review cc/ ?
mkwst@, could you review tools/ ?
cpu@, could you review media/mojo/ ?

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types.h
File media/base/video_types.h (right):

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types...
media/base/video_types.h:56: PIXEL_FORMAT_Y8 = 22,   // single 8bpp plane.
On 2016/09/20 21:52:24, fbarchard1 wrote:
> // Single 8 bpp plane.

Done.

https://codereview.chromium.org/2113243003/diff/120001/media/base/video_types...
media/base/video_types.h:57: PIXEL_FORMAT_Y16 = 23,  // single 16bpp plane.
On 2016/09/20 21:52:24, fbarchard1 wrote:
> // Single 16 bpp plane.

Done.

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
media/renderers/skcanvas_video_renderer.cc:613: case PIXEL_FORMAT_Y8:
On 2016/09/20 21:52:24, fbarchard1 wrote:
> Y8 is supported by libyuv if you want to add the converter to ARGB.
> Use either I400ToARGB or J400ToARGB depending if you want bt601 constrained
> range of 16 to 240, or JPeg full range 601 coefficients.

Thank you for suggestion. My plan is to draw Y8 directly by compositor renderer.
If the conversion is necessary, we will add J400ToARGB conversion in
https://codereview.chromium.org/2121043002/ when we actually support Y8
rendering.

[danakj, 2016-09-22 20:55:20]

https://codereview.chromium.org/2113243003/diff/140001/cc/resources/video_res...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/140001/cc/resources/video_res...
cc/resources/video_resource_updater.cc:347: NOTREACHED();
Please don't both DCHECK and handle the case. Choose one. Return or DCHECK.

[fbarchard1, 2016-09-22 21:06:57]

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
media/renderers/skcanvas_video_renderer.cc:613: case PIXEL_FORMAT_Y8:
On 2016/09/21 09:00:00, dshwang wrote:
> On 2016/09/20 21:52:24, fbarchard1 wrote:
> > Y8 is supported by libyuv if you want to add the converter to ARGB.
> > Use either I400ToARGB or J400ToARGB depending if you want bt601 constrained
> > range of 16 to 240, or JPeg full range 601 coefficients.
> 
> Thank you for suggestion. My plan is to draw Y8 directly by compositor
renderer.
> If the conversion is necessary, we will add J400ToARGB conversion in
> https://codereview.chromium.org/2121043002/ when we actually support Y8
> rendering.

Add a TODO to that effect?
Not all drivers support Y8 or Y16.  Some would have P8 that could be used as a
fallback.  But the software conversion is trivial/fast.

[inactive_dshwang_plz_cc_intel, 2016-09-26 13:02:09]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[dshwang, 2016-09-26 13:02:23]

Thank you for reviewing. resolved concerns.

danakj@, could you review cc/ ?
mkwst@, could you review tools/ ?
cpu@, could you review media/mojo/ ?

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
File media/renderers/skcanvas_video_renderer.cc (right):

https://codereview.chromium.org/2113243003/diff/120001/media/renderers/skcanv...
media/renderers/skcanvas_video_renderer.cc:613: case PIXEL_FORMAT_Y8:
On 2016/09/22 21:06:57, fbarchard1 wrote:
> On 2016/09/21 09:00:00, dshwang wrote:
> > On 2016/09/20 21:52:24, fbarchard1 wrote:
> > > Y8 is supported by libyuv if you want to add the converter to ARGB.
> > > Use either I400ToARGB or J400ToARGB depending if you want bt601
constrained
> > > range of 16 to 240, or JPeg full range 601 coefficients.
> > 
> > Thank you for suggestion. My plan is to draw Y8 directly by compositor
> renderer.
> > If the conversion is necessary, we will add J400ToARGB conversion in
> > https://codereview.chromium.org/2121043002/ when we actually support Y8
> > rendering.
> 
> Add a TODO to that effect?
> Not all drivers support Y8 or Y16.  Some would have P8 that could be used as a
> fallback.  But the software conversion is trivial/fast.

Done. Added the comment you explained.

https://codereview.chromium.org/2113243003/diff/140001/cc/resources/video_res...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/140001/cc/resources/video_res...
cc/resources/video_resource_updater.cc:347: NOTREACHED();
On 2016/09/22 20:55:20, danakj wrote:
> Please don't both DCHECK and handle the case. Choose one. Return or DCHECK.

Done. Choose DCHECK

[commit-bot: I haz the power, 2016-09-26 13:02:24]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-09-26 13:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 13:02:34]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[Mike West, 2016-09-26 13:09:21]

On 2016/09/26 at 13:02:23, dongseong.hwang wrote:
> mkwst@, could you review tools/ ?

Sorry, I'm only in the histograms OWNERS file for UseCounter changes in Blink.
Please grab a "real" OWNER for this change. :)

[dshwang, 2016-09-26 17:45:08]

dongseong.hwang@intel.com changed reviewers:
- mkwst@chromium.org

[dshwang, 2016-09-26 17:45:54]

dongseong.hwang@intel.com changed reviewers:
+ asvitkine@chromium.org

[dshwang, 2016-09-26 17:46:45]

On 2016/09/26 13:09:21, Mike West (OOO until 26th) wrote:
> On 2016/09/26 at 13:02:23, dongseong.hwang wrote:
> > mkwst@, could you review tools/ ?
> 
> Sorry, I'm only in the histograms OWNERS file for UseCounter changes in Blink.
> Please grab a "real" OWNER for this change. :)

Ok, thank you.

danakj@, could you review cc/ ?
asvitkine@, could you review tools/ ?
cpu@, could you review media/mojo/ ?

[Alexei Svitkine (slow), 2016-09-26 18:08:28]

lgtm

[danakj, 2016-09-26 18:52:07]

cc LGTM

https://codereview.chromium.org/2113243003/diff/160001/cc/resources/video_res...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2113243003/diff/160001/cc/resources/video_res...
cc/resources/video_resource_updater.cc:340: NOTREACHED();
You can write this DCHECK_NE(bit_per_channel_, 16)

[dshwang, 2016-09-27 12:24:48]

Patchset #6 (id:160001) has been deleted

[inactive_dshwang_plz_cc_intel, 2016-09-27 12:25:01]

The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 12:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 12:25:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:25:14]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[dshwang, 2016-09-27 12:25:27]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2016-09-27 12:25:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
fbarchard@google.com, hubbe@chromium.org, danakj@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2113243003/#ps180001
(title: "resolved reviewers' comments")

[commit-bot: I haz the power, 2016-09-27 12:25:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 12:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:25:47]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[dshwang, 2016-09-27 12:27:59]

The CQ bit was unchecked by dongseong.hwang@intel.com

[dshwang, 2016-09-27 12:41:40]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-09-27 12:41:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 12:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:41:57]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[dshwang, 2016-09-27 14:19:22]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-09-27 14:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:19:36]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[dshwang, 2016-09-27 14:22:29]

Description was changed from

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
==========

[dshwang, 2016-09-27 14:22:34]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-09-27 14:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:32:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dshwang, 2016-09-27 14:42:13]

dongseong.hwang@intel.com changed reviewers:
+ meacer@chromium.org
- asvitkine@chromium.org

[dshwang, 2016-09-27 14:43:02]

meacer@, could you review media/mojo/? asvitkine@ already called lgtm.

[cpu_(ooo_6.6-7.5), 2016-09-27 15:41:41]

sorry I am not familiar with media/mojo

[dshwang, 2016-09-28 18:00:07]

On 2016/09/27 15:41:41, cpu wrote:
> sorry I am not familiar with media/mojo

Mustafa, could you review media/mojo/?

[dshwang, 2016-09-28 18:00:22]

dongseong.hwang@intel.com changed reviewers:
- cpu@chromium.org

[meacer, 2016-09-28 19:12:57]

Sorry for the delay. media/mojo/ LGTM.

[dshwang, 2016-09-28 22:37:59]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2016-09-28 22:38:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 22:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 22:42:06]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dshwang, 2016-09-29 09:46:37]

Description was changed from

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
==========

to

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[dshwang, 2016-09-29 09:46:45]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2016-09-29 09:46:45]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org,
danakj@chromium.org, asvitkine@chromium.org, fbarchard@google.com,
meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2113243003/#ps200001
(title: "rebase to land")

[commit-bot: I haz the power, 2016-09-29 09:47:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dshwang, 2016-09-29 09:48:55]

The CQ bit was unchecked by dongseong.hwang@intel.com

[dshwang, 2016-09-29 09:48:55]

Patchset #7 (id:200001) has been deleted

[dshwang, 2016-09-29 09:54:22]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2016-09-29 09:54:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org,
danakj@chromium.org, asvitkine@chromium.org, fbarchard@google.com,
meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2113243003/#ps220001
(title: "rebase to land")

[commit-bot: I haz the power, 2016-09-29 09:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 10:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 10:49:03]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dshwang, 2016-09-29 11:16:12]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2016-09-29 11:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org,
danakj@chromium.org, asvitkine@chromium.org, fbarchard@google.com,
meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2113243003/#ps240001
(title: "rebase to land")

[dshwang, 2016-09-29 11:16:21]

Patchset #7 (id:220001) has been deleted

[commit-bot: I haz the power, 2016-09-29 11:16:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 12:38:28]

Committed patchset #7 (id:240001)

[commit-bot: I haz the power, 2016-09-29 12:40:08]

Description was changed from

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
media: Introduce Y8 and Y16 video pixel format

Depth and infrared camera uses these format.

TODO: native support for depth camera.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/ea1ddc4e14b1b51a8dcbc29cabcec6513127e0c9
Cr-Commit-Position: refs/heads/master@{#421804}
==========

[commit-bot: I haz the power, 2016-09-29 12:40:10]

Patchset 7 (id:??) landed as
https://crrev.com/ea1ddc4e14b1b51a8dcbc29cabcec6513127e0c9
Cr-Commit-Position: refs/heads/master@{#421804}