Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2113113002: mash: Move chromeos audio system tray files to //ash/common (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move chromeos audio system tray files to //ash/common It is a dependency of SystemTray. * Move files to //ash/common/system/chromeos/audio * Fix include guards * Fix IWYU BUG=619636 TEST=ash_unittests Committed: https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604 Cr-Commit-Position: refs/heads/master@{#403348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -507 lines) Patch
M ash/ash.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
A + ash/common/system/chromeos/audio/audio_detailed_view.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/audio/tray_audio_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/audio/tray_audio_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio_chromeos.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ash/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
James Cook
msw, can I get a rubber-stamp?
4 years, 5 months ago (2016-06-30 22:05:51 UTC) #2
msw
lgtm
4 years, 5 months ago (2016-06-30 22:07:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113113002/1
4 years, 5 months ago (2016-06-30 22:09:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:49:04 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:52:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604
Cr-Commit-Position: refs/heads/master@{#403348}

Powered by Google App Engine
This is Rietveld 408576698