Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2108403004: mash: Move several chromeos system tray items to //ash/common (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@audio
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move several chromeos system tray items to //ash/common * //ash/system/chromeos/bluetooth * //ash/system/chromeos/enterprise * //ash/system/chromeos/supervised * //ash/system/chromeos/tray_caps_lock.* Purely mechanical, no functional changes. BUG=619636 TEST=ash_unittests Committed: https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03 Cr-Commit-Position: refs/heads/master@{#403388}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1652 lines) Patch
M ash/ash.gyp View 1 6 chunks +12 lines, -12 lines 0 comments Download
A + ash/common/system/chromeos/bluetooth/bluetooth_notification_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/bluetooth/tray_bluetooth.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/enterprise/tray_enterprise.h View 2 chunks +3 lines, -7 lines 0 comments Download
A + ash/common/system/chromeos/enterprise/tray_enterprise.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/supervised/custodian_info_tray_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/supervised/tray_supervised_user.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/chromeos/tray_caps_lock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/chromeos/tray_caps_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D ash/system/chromeos/bluetooth/bluetooth_notification_controller.h View 1 chunk +0 lines, -94 lines 0 comments Download
D ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D ash/system/chromeos/bluetooth/tray_bluetooth.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +0 lines, -452 lines 0 comments Download
D ash/system/chromeos/enterprise/tray_enterprise.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ash/system/chromeos/enterprise/tray_enterprise.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D ash/system/chromeos/supervised/custodian_info_tray_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ash/system/chromeos/supervised/tray_supervised_user.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ash/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D ash/system/chromeos/supervised/tray_supervised_user_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D ash/system/chromeos/tray_caps_lock.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ash/system/chromeos/tray_caps_lock.cc View 1 chunk +0 lines, -218 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
James Cook
msw, can I get a rubber stamp?
4 years, 5 months ago (2016-06-30 23:15:31 UTC) #2
msw
lgtm
4 years, 5 months ago (2016-06-30 23:34:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108403004/20001
4 years, 5 months ago (2016-07-01 01:08:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 01:54:36 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 01:54:42 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:57:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03
Cr-Commit-Position: refs/heads/master@{#403388}

Powered by Google App Engine
This is Rietveld 408576698