Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2113033002: Reland "Build delegation for perf tryjobs" (Closed)

Created:
4 years, 5 months ago by Ziqi Xiong
Modified:
4 years, 5 months ago
Reviewers:
RobertoCN
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland issue: https://codereview.chromium.org/2103133005/ In original issue, build_state.is_completed is checking for stdout['status'] instead of stdout['build']['status'] BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/c62890265b947bf33fe45001298f3522ae205a01

Patch Set 1 #

Patch Set 2 : update step data and expectation files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7747 lines, -6014 lines) Patch
M scripts/slave/recipe_modules/perf_try/__init__.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/api.py View 1 4 chunks +153 lines, -7 lines 0 comments Download
A scripts/slave/recipe_modules/perf_try/build_state.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 6 chunks +112 lines, -25 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +196 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +156 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 10 chunks +112 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 5 chunks +93 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 8 chunks +176 lines, -104 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 8 chunks +176 lines, -104 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 8 chunks +134 lines, -103 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 1 8 chunks +176 lines, -104 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ziqi Xiong
new cl on build delegation that fixes the key error
4 years, 5 months ago (2016-06-30 20:30:54 UTC) #2
RobertoCN
On 2016/06/30 20:30:54, Ziqi Xiong wrote: > new cl on build delegation that fixes the ...
4 years, 5 months ago (2016-06-30 21:26:59 UTC) #3
RobertoCN
lgtm
4 years, 5 months ago (2016-06-30 22:24:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113033002/10001
4 years, 5 months ago (2016-06-30 22:24:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10001) as https://chromium.googlesource.com/chromium/tools/build/+/c62890265b947bf33fe45001298f3522ae205a01
4 years, 5 months ago (2016-06-30 22:28:55 UTC) #9
RobertoCN
4 years, 5 months ago (2016-06-30 23:19:06 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10001) has been created in
https://codereview.chromium.org/2117643002/ by robertocn@chromium.org.

The reason for reverting is: There is a problem with the build request's
formatting.

The field `buildername` should be called `builder_name`

Please fix this and re-land.

Powered by Google App Engine
This is Rietveld 408576698