runtime/vm/flow_graph_builder.cc - Issue 2112973002: Remove invalid assertion in the optimizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2112973002: Remove invalid assertion in the optimizer (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Mark initializing field stores in the parser Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index d1e0b857c40340aed606382fbb1d3d87c7f6896a..5bec82ed2287b764024b75f2b4037f5c457aed5a 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -3660,7 +3660,7 @@ void EffectGraphVisitor::VisitStoreInstanceFieldNode(

kEmitStoreBarrier,

token_pos);

// Maybe initializing unboxed store.

- store->set_is_potential_unboxed_initialization(true);

+ store->set_is_potential_unboxed_initialization(node->is_initializer());

ReturnDefinition(store);

}