runtime/vm/jit_optimizer.cc - Issue 2112973002: Remove invalid assertion in the optimizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2112973002: Remove invalid assertion in the optimizer (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Mark initializing field stores in the parser Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/jit_optimizer.cc

diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc

index 7ff3b0c825cb43d118bdd13e0681be5c43f9d3d8..62fec9f10eaf4f0e55098b72f20ba90b38cb4e10 100644

--- a/runtime/vm/jit_optimizer.cc

+++ b/runtime/vm/jit_optimizer.cc

@@ -2775,7 +2775,6 @@ void JitOptimizer::VisitStaticCall(StaticCallInstr* call) {

void JitOptimizer::VisitStoreInstanceField(

StoreInstanceFieldInstr* instr) {

if (instr->IsUnboxedStore()) {

- ASSERT(instr->is_potential_unboxed_initialization_);

// Determine if this field should be unboxed based on the usage of getter

// and setter functions: The heuristic requires that the setter has a

// usage count of at least 1/kGetterSetterRatio of the getter usage count.