Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2112973002: Remove invalid assertion in the optimizer (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove invalid assertion in the optimizer. We can have stores inlined in the optimizer that are not initializing stores. Mark initializing stores in the parser instead to distinguish initializing- and non-initializing stores more precisely. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/7f0273f83ea3151c576c4c1184bac3b63b372d72

Patch Set 1 #

Patch Set 2 : Mark initializing field stores in the parser #

Total comments: 2

Patch Set 3 : added const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M runtime/vm/ast.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Florian Schneider
4 years, 5 months ago (2016-06-30 19:58:28 UTC) #4
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2112973002/diff/20001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/2112973002/diff/20001/runtime/vm/ast.h#newcode1274 runtime/vm/ast.h:1274: bool is_initializer_; maybe make this const bool?
4 years, 5 months ago (2016-07-01 16:28:23 UTC) #5
Florian Schneider
https://codereview.chromium.org/2112973002/diff/20001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/2112973002/diff/20001/runtime/vm/ast.h#newcode1274 runtime/vm/ast.h:1274: bool is_initializer_; On 2016/07/01 16:28:23, Vyacheslav Egorov (Google) wrote: ...
4 years, 5 months ago (2016-07-01 16:54:31 UTC) #6
Florian Schneider
4 years, 5 months ago (2016-07-01 16:55:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
7f0273f83ea3151c576c4c1184bac3b63b372d72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698