Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: runtime/vm/parser.cc

Issue 2112973002: Remove invalid assertion in the optimizer (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: added const Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 46196029d1a70e4fa6ea925a2f6639f9813bda13..4aab2809a987e0c1339e4d0930e74eb308dfa7c2 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -1473,7 +1473,8 @@ SequenceNode* Parser::ParseInstanceSetter(const Function& func) {
EnsureExpressionTemp();
StoreInstanceFieldNode* store_field =
- new StoreInstanceFieldNode(ident_pos, receiver, field, value);
+ new StoreInstanceFieldNode(ident_pos, receiver, field, value,
+ /* is_initializer = */ false);
current_block_->statements->Add(store_field);
current_block_->statements->Add(new ReturnNode(ST(ident_pos)));
return CloseBlock();
@@ -2609,7 +2610,8 @@ AstNode* Parser::ParseInitializer(const Class& cls,
initialized_fields, instance, &field, init_expr);
if (initializer == NULL) {
initializer =
- new(Z) StoreInstanceFieldNode(field_pos, instance, field, init_expr);
+ new(Z) StoreInstanceFieldNode(field_pos, instance, field, init_expr,
+ /* is_initializer = */ true);
}
return initializer;
}
@@ -2735,7 +2737,8 @@ void Parser::ParseInitializedInstanceFields(const Class& cls,
new StoreInstanceFieldNode(field.token_pos(),
instance,
field,
- init_expr);
+ init_expr,
+ /* is_initializer = */ true);
current_block_->statements->Add(field_init);
}
}
@@ -3198,7 +3201,8 @@ SequenceNode* Parser::ParseConstructor(const Function& func) {
value);
if (initializer == NULL) {
initializer = new(Z) StoreInstanceFieldNode(
- param.name_pos, instance, field, value);
+ param.name_pos, instance, field, value,
+ /* is_initializer = */ true);
}
current_block_->statements->Add(initializer);
}
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698