content/browser/renderer_host/text_input_client_mac_unittest.mm - Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_client_mac_unittest.mm

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_delegate.h ('K') | « content/browser/renderer_host/render_widget_host_view_mac_unittest.mm ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_client_mac_unittest.mm

diff --git a/content/browser/renderer_host/text_input_client_mac_unittest.mm b/content/browser/renderer_host/text_input_client_mac_unittest.mm

index e953183ddaeeb461436a45375b9017ecdae64786..ae1071b93be0d279e7494c98d2ad9d9ba89fd747 100644

--- a/content/browser/renderer_host/text_input_client_mac_unittest.mm

+++ b/content/browser/renderer_host/text_input_client_mac_unittest.mm

@@ -36,6 +36,7 @@ class MockRenderWidgetHostDelegate : public RenderWidgetHostDelegate {

void Copy() override {}

void Paste() override {}

void SelectAll() override {}

+ bool HasMouseLock(RenderWidgetHostImpl*) override { return false; }

};

// This test does not test the WebKit side of the dictionary system (which