content/browser/renderer_host/render_widget_host_delegate.h - Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_child_frame.cc ('K') | « content/browser/frame_host/render_widget_host_view_guest_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_delegate.h

diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h

index 6777b9c999261e7fc63cbc10a9d51c45dbc9a3ff..bf0a80c3423a2f51fd84c82099218b9b78d478c7 100644

--- a/content/browser/renderer_host/render_widget_host_delegate.h

+++ b/content/browser/renderer_host/render_widget_host_delegate.h

@@ -167,6 +167,9 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {

// Notification that the widget has lost the mouse lock.

virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {}

+ // Returns true if |render_widget_host| holds the mouse lock.

+ virtual bool HasMouseLock(RenderWidgetHostImpl* render_widget_host) = 0;

Charlie Reis 2016/07/06 17:41:47 Maybe we should have a default implementation that

lfg 2016/07/07 20:17:35 Done. I had that before, but clang complained abou

// Called when the widget has sent a compositor proto. This is used in Btlimp

// mode with the RemoteChannel compositor.

virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,