Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 // Returns the display mode for the view. 160 // Returns the display mode for the view.
161 virtual blink::WebDisplayMode GetDisplayMode( 161 virtual blink::WebDisplayMode GetDisplayMode(
162 RenderWidgetHostImpl* render_widget_host) const; 162 RenderWidgetHostImpl* render_widget_host) const;
163 163
164 // Notification that the widget has lost capture. 164 // Notification that the widget has lost capture.
165 virtual void LostCapture(RenderWidgetHostImpl* render_widget_host) {} 165 virtual void LostCapture(RenderWidgetHostImpl* render_widget_host) {}
166 166
167 // Notification that the widget has lost the mouse lock. 167 // Notification that the widget has lost the mouse lock.
168 virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {} 168 virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {}
169 169
170 // Returns true if |render_widget_host| holds the mouse lock.
171 virtual bool HasMouseLock(RenderWidgetHostImpl* render_widget_host) = 0;
Charlie Reis 2016/07/06 17:41:47 Maybe we should have a default implementation that
lfg 2016/07/07 20:17:35 Done. I had that before, but clang complained abou
172
170 // Called when the widget has sent a compositor proto. This is used in Btlimp 173 // Called when the widget has sent a compositor proto. This is used in Btlimp
171 // mode with the RemoteChannel compositor. 174 // mode with the RemoteChannel compositor.
172 virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host, 175 virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
173 const std::vector<uint8_t>& proto) {} 176 const std::vector<uint8_t>& proto) {}
174 177
175 // Called when the visibility of the RenderFrameProxyHost in outter 178 // Called when the visibility of the RenderFrameProxyHost in outter
176 // WebContents changes. This method is only called on an inner WebContents and 179 // WebContents changes. This method is only called on an inner WebContents and
177 // will eventually notify all the RenderWidgetHostViews belonging to that 180 // will eventually notify all the RenderWidgetHostViews belonging to that
178 // WebContents. 181 // WebContents.
179 virtual void OnRenderFrameProxyVisibilityChanged(bool visible) {} 182 virtual void OnRenderFrameProxyVisibilityChanged(bool visible) {}
180 183
181 // Update the renderer's cache of the screen rect of the view and window. 184 // Update the renderer's cache of the screen rect of the view and window.
182 virtual void SendScreenRects() {} 185 virtual void SendScreenRects() {}
183 186
184 // Notifies that the main frame in the renderer has performed the first paint 187 // Notifies that the main frame in the renderer has performed the first paint
185 // after a navigation. 188 // after a navigation.
186 virtual void OnFirstPaintAfterLoad(RenderWidgetHostImpl* render_widget_host) { 189 virtual void OnFirstPaintAfterLoad(RenderWidgetHostImpl* render_widget_host) {
187 } 190 }
188 191
189 // Returns the TextInputManager tracking text input state. 192 // Returns the TextInputManager tracking text input state.
190 virtual TextInputManager* GetTextInputManager(); 193 virtual TextInputManager* GetTextInputManager();
191 194
192 protected: 195 protected:
193 virtual ~RenderWidgetHostDelegate() {} 196 virtual ~RenderWidgetHostDelegate() {}
194 }; 197 };
195 198
196 } // namespace content 199 } // namespace content
197 200
198 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 201 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698