content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc - Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_child_frame.cc ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest_unittest.cc » ('j') | content/browser/renderer_host/render_widget_host_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

index ca5d43677e80b3340f98a5eb5fc55432093e6c61..6949054cb56aa197af2fd48ac72be8a14019dc70 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

@@ -39,6 +39,7 @@ class MockRenderWidgetHostDelegate : public RenderWidgetHostDelegate {

void Copy() override {}

void Paste() override {}

void SelectAll() override {}

+ bool HasMouseLock(RenderWidgetHostImpl*) override { return false; }

};

class MockCrossProcessFrameConnector : public CrossProcessFrameConnector {