Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: src/source-position-table.h

Issue 2112853002: Do not record source positions for non-JS or native script code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@simplifyjitlogging
Patch Set: update test expectation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | src/source-position-table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/source-position-table.h
diff --git a/src/source-position-table.h b/src/source-position-table.h
index bd822410cb67c4c8f4511e0d60d6c3d24df5e61e..c85d2371bfe1f0b023d1e5684d955102401e5ad1 100644
--- a/src/source-position-table.h
+++ b/src/source-position-table.h
@@ -32,7 +32,10 @@ struct PositionTableEntry {
class SourcePositionTableBuilder {
public:
- SourcePositionTableBuilder(Isolate* isolate, Zone* zone);
+ enum RecordingMode { OMIT_SOURCE_POSITIONS, RECORD_SOURCE_POSITIONS };
+
+ SourcePositionTableBuilder(Isolate* isolate, Zone* zone,
+ RecordingMode mode = RECORD_SOURCE_POSITIONS);
void EndJitLogging(AbstractCode* code);
@@ -42,7 +45,10 @@ class SourcePositionTableBuilder {
private:
void AddEntry(const PositionTableEntry& entry);
+ inline bool Omit() const { return mode_ == OMIT_SOURCE_POSITIONS; }
+
Isolate* isolate_;
+ RecordingMode mode_;
ZoneVector<byte> bytes_;
#ifdef ENABLE_SLOW_DCHECKS
ZoneVector<PositionTableEntry> raw_entries_;
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | src/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698